-
Notifications
You must be signed in to change notification settings - Fork 0
parallel accumulate #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel accumulate #361
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 80.63% 80.66% +0.03%
==========================================
Files 378 378
Lines 33216 33313 +97
==========================================
+ Hits 26784 26873 +89
- Misses 6432 6440 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The changes introduce parallel processing to the accumulation logic, which is a significant architectural improvement. The implementation correctly uses task groups and handles state management across parallel tasks by batching services based on their dependencies. The removal of PVM step logging into a conditional flag is also a good performance optimization. One minor issue was found regarding removed documentation. Review SuggestionsBlockchain/Sources/Blockchain/RuntimeProtocols/Accumulation.swift:498-499 Two lines of comments describing the purpose of the |
| public init(config: PvmConfig, invocationContext: (any InvocationContext)? = nil) { | ||
| self.config = config | ||
| self.invocationContext = invocationContext | ||
| enableStepLogging = ProcessInfo.processInfo.environment["PVM_STEP_LOGGING"] != nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we only access env from main file so this won't become a "hidden" setting. It also make it possible to toggle this value in different way under other context (e.g. in tests)
Uh oh!
There was an error while loading. Please reload this page.