-
Notifications
You must be signed in to change notification settings - Fork 0
fixes 0.7.0 #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes 0.7.0 #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review found three critical issues. The first is an incorrect order of operations in gas consumption logic, which could lead to an invalid state. The second is a flawed balance check in the transfer function, potentially allowing accounts to fall below their minimum required balance. The third is an incorrect test expectation for encoding an array of nils, which does not match the encoder's behavior.
Blockchain/Sources/Blockchain/VMInvocations/HostCall/HostCalls.swift
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 80.67% 81.46% +0.79%
==========================================
Files 378 378
Lines 33313 33315 +2
==========================================
+ Hits 26876 27141 +265
+ Misses 6437 6174 -263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.