Skip to content

Conversation

@qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Sep 2, 2025

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review found three critical issues. The first is an incorrect order of operations in gas consumption logic, which could lead to an invalid state. The second is a flawed balance check in the transfer function, potentially allowing accounts to fall below their minimum required balance. The third is an incorrect test expectation for encoding an array of nils, which does not match the encoder's behavior.

@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 90.21739% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.46%. Comparing base (03a06fc) to head (9460928).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ces/Blockchain/RuntimeProtocols/Accumulation.swift 84.61% 4 Missing ⚠️
PolkaVM/Sources/PolkaVM/Engine.swift 60.00% 2 Missing ⚠️
PolkaVM/Sources/PolkaVM/ProgramCode.swift 94.28% 2 Missing ⚠️
...ain/Sources/Blockchain/State/ServiceAccounts.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   80.67%   81.46%   +0.79%     
==========================================
  Files         378      378              
  Lines       33313    33315       +2     
==========================================
+ Hits        26876    27141     +265     
+ Misses       6437     6174     -263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qiweiii qiweiii marked this pull request as ready for review September 2, 2025 12:49
@xlc xlc merged commit 7517701 into master Sep 2, 2025
6 checks passed
@xlc xlc deleted the debug-fix-0.7.0-1 branch September 2, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants