Skip to content

Update Polkadot E2E proxy snapshots #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xlc merged 2 commits into from
Jul 21, 2025
Merged

Update Polkadot E2E proxy snapshots #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
715fcdf
Update Polkadot `CancelProxy` test
rockbmb Jul 21, 2025
d61fe8c
Update Polkadot snapshots
rockbmb Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions packages/polkadot/src/__snapshots__/polkadot.proxy.e2e.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,6 +1743,25 @@ exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed pr
]
`;

exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed proxy calls for CancelProxy > events for proxy type CancelProxy, pallet multisig, call as_multi 1`] = `
[
{
"data": {
"result": {
"Err": {
"Module": {
"error": "0x00000000",
"index": 30,
},
},
},
},
"method": "ProxyExecuted",
"section": "proxy",
},
]
`;

exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed proxy calls for CancelProxy > events for proxy type CancelProxy, pallet proxy, call reject_announcement 1`] = `
[
{
Expand All @@ -1762,6 +1781,57 @@ exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed pr
]
`;

exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed proxy calls for CancelProxy > events for proxy type CancelProxy, pallet utility, call batch 1`] = `
[
{
"data": {},
"method": "BatchCompleted",
"section": "utility",
},
{
"data": {
"result": "Ok",
},
"method": "ProxyExecuted",
"section": "proxy",
},
]
`;

exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed proxy calls for CancelProxy > events for proxy type CancelProxy, pallet utility, call batch_all 1`] = `
[
{
"data": {},
"method": "BatchCompleted",
"section": "utility",
},
{
"data": {
"result": "Ok",
},
"method": "ProxyExecuted",
"section": "proxy",
},
]
`;

exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed proxy calls for CancelProxy > events for proxy type CancelProxy, pallet utility, call force_batch 1`] = `
[
{
"data": {},
"method": "BatchCompleted",
"section": "utility",
},
{
"data": {
"result": "Ok",
},
"method": "ProxyExecuted",
"section": "proxy",
},
]
`;

exports[`Polkadot Proxy > filtering tests for permitted proxy calls > allowed proxy calls for Governance > events for proxy type Governance, pallet bounties, call propose_bounty 1`] = `
[
{
Expand Down
22 changes: 5 additions & 17 deletions packages/shared/src/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,15 +814,11 @@ async function buildAllowedProxyActions<
...proxyActionBuilder.buildUtilityAction(),
])
.with('CancelProxy', () => {
const actions = [...proxyActionBuilder.buildProxyRejectAnnouncementAction()]

// TODO: `utility` and `system` calls should be callable by cancel proxies, but on Polkadot, this is
// currently not the case. Kusama has already had a runtime upgrade with this.
// PR: https://github.com/polkadot-fellows/runtimes/pull/740
if (!['polkadot'].includes(chainName)) {
actions.push(...proxyActionBuilder.buildUtilityAction())
actions.push(...proxyActionBuilder.buildMultisigAction())
}
const actions = [
...proxyActionBuilder.buildProxyRejectAnnouncementAction(),
...proxyActionBuilder.buildUtilityAction(),
...proxyActionBuilder.buildMultisigAction(),
]

return actions
})
Expand Down Expand Up @@ -1002,14 +998,6 @@ async function buildDisallowedProxyActions<
...proxyActionBuilder.buildSystemAction(),
]

// TODO: `utility` and `system` calls should be callable by cancel proxies, but on Polkadot, this is
// currently not the case. Kusama has already had a runtime upgrade with this.
// PR: https://github.com/polkadot-fellows/runtimes/pull/740
if (['polkadot'].includes(chainName)) {
actions.push(...proxyActionBuilder.buildUtilityAction())
actions.push(...proxyActionBuilder.buildMultisigAction())
}

return actions
})

Expand Down