Addenda to preimage tests #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockbmb
added
enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+712
to
+713
| const oversizedBytesArray = Array(maxPreimageSize + 1).fill(1) | ||
| const oversizedBytes = client.api.createType('Bytes', oversizedBytesArray) |
Contributor
There was a problem hiding this comment.
Using Array(maxPreimageSize + 1) creates a sparse/dense array of numbers which is memory inefficient for binary data. Use new Uint8Array(maxPreimageSize + 1).fill(1) instead, which createType supports directly.
Collaborator
Author
There was a problem hiding this comment.
Unit8Array was used before, and due to a SCALE + PJS interaction that I didn't delve too deeply into, the maximum allowed size of the preimage ended up being 64 bytes.
@andreitrand not a cabal answer, but here's the fix!
xlc
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #471 . Closes #481 .