This repository was archived by the owner on Oct 23, 2024. It is now read-only.
setMaxResolution for adaptive video#699
Open
thegobot wants to merge 20 commits intoopen-webrtc-toolkit:masterfrom
Open
setMaxResolution for adaptive video#699thegobot wants to merge 20 commits intoopen-webrtc-toolkit:masterfrom
thegobot wants to merge 20 commits intoopen-webrtc-toolkit:masterfrom
Conversation
| me->forceKeyFrame(outStreamID); | ||
| } | ||
|
|
||
| void VideoTranscoder::setMaxResolution(const v8::FunctionCallbackInfo<v8::Value>& args){ |
Collaborator
There was a problem hiding this comment.
This function is not registered in node layer through "init" function in line 24. Who will call this function?
Contributor
Author
|
This works for me. Maybe I made a crooked patch, I'm not good at GIT. Try adding all the wrappers yourself. I think this patch is useful. It's simple |
qwu16
reviewed
Apr 6, 2023
| @@ -1,4 +1,4 @@ | |||
| Apache License | |||
| Apache License!!! | |||
Collaborator
There was a problem hiding this comment.
Why adding this change to license and readme file?
| this.id = spec.id; | ||
| this.key = spec.key; | ||
| this.url = spec.url || '/'; | ||
| this.url = spec.url || window.location.pathname.replace(/\/console.*/g, "/"); |
Collaborator
There was a problem hiding this comment.
code conflict with latest master code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For adaptive video, you need to limit the transcoded resolution. I needed this to limit the output bndwidth for rtmp (i use streaming-out) and probably to reduce the load on the processor
Usage:
owt-server/source/agent/video/index.js
Line 277 in 5fc8bf2
Please see my question
#698