fixed bugs in srd-2024 CreatureAction data (closes #847) #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustjohnson
approved these changes
Jan 4, 2026
Collaborator
augustjohnson
left a comment
augustjohnson
left a comment
There was a problem hiding this comment.
Nice catch on the data conversion errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses numerous small errors in the 2024 SRD creature stat-blocks dataset:
(Recharge X),(1/Day), etc.) from CreatureAction name fields (the"usage_type"and"usage_param"fields handle this)"form-condition"field"uses_type": "RECHARGE"to"uses_type": "RECHARGE_ON_ROLL", which is how this property appears in all our other data (perhaps this should be enforced using a enum?)Related Issue
Closes #847
Touches on #534 (but doesn't resolve it)
How was this tested
pytestsuite (all tests are passing)