Fix datatype member dependency ordering during NodeSet load#293
Fix datatype member dependency ordering during NodeSet load#293fischjo3SICKAG wants to merge 3 commits intoopen62541:masterfrom
Conversation
|
I investigated the missing binary encoding IDs for some DI datatypes. Root cause: some NodeSets model HasEncoding only as an inverse reference on the I pushed a fix that:
The new test validates two datatypes: one with forward HasEncoding and one with |
|
I investigated another datatype import issue in this PR: loading empty structures (Definition present, but fieldCnt = 0). Root cause:
Proposed fix:
Regression test:
I would appreciate a focused review of this part because I am not fully sure whether this handling is correct for all datatype edge cases. |
This pull request fixes node sorting during NodeSet loading to address
open62541 issue 7784.
What changed:
UADataTypenodes: a datatype is now onlyconsidered ready when all datatype member types defined in the same NodeSet are
already available.
loading_order_fix) with a minimal NodeSet whereTypeAdepends onTypeBbut appears first in XML order.Behavior before/after:
Validation:
1.5at commiteabfbba.Open question for maintainers:
memberTypesReady()implementation performs thecorrect dependency checks in all cases, especially regarding which data from
the
nodesetparameter should be used to decide that all required datatypesare available. A review of this function would be very helpful.