fix(ci): chain build-phar workflow from release-please #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions events triggered by GITHUB_TOKEN don't trigger other workflows (security feature to prevent loops). This meant the build-phar workflow never ran when release-please created releases. Changes: - Convert build-phar to reusable workflow (workflow_call) and call it directly from release-please after release creation - Add build-phar-on-release.yml wrapper for manual release events - Add optional tag_name input to workflow_dispatch for attaching PHAR to existing releases - Fix checkout to use tag ref when tag_name is provided - Update build.php to get version from BUILD_VERSION env var or git describe instead of hardcoded value Fixes #20 Co-Authored-By: Claude Opus 4.5 <[email protected]>
kojiromike
force-pushed
the
release-please-chain
branch
from
2d35b45 to
533effc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
workflow_call(fixes GITHUB_TOKEN not triggering other workflows)build-phar-on-release.ymlwrapper for manualrelease: createdeventstag_nameinput toworkflow_dispatchfor attaching PHAR to existing releasestag_nameis providedbuild.phpto determine version fromBUILD_VERSIONenv var orgit describe --tagsFixes #20
🤖 Generated with Claude Code