Skip to content

refactor: catch Throwable instead of Exception #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kojiromike merged 1 commit into from
Jan 17, 2026
Merged

refactor: catch Throwable instead of Exception #25

kojiromike merged 1 commit into from
Jan 17, 2026

Conversation

@kojiromike
Copy link
Contributor

@kojiromike kojiromike commented Jan 17, 2026

Summary

  • Replace catch (Exception) with catch (Throwable) across the codebase
  • Ensures we catch both Exception and Error subclasses (TypeError, ArgumentCountError, etc.)

Closes #24

Test plan

  • Verify existing tests still pass
  • CI checks pass

🤖 Generated with Claude Code

@kojiromike @claude
refactor: catch Throwable instead of Exception
6af7204 
Since PHP 7, Throwable is the base interface for all errors and
exceptions. Catching Exception misses Error subclasses like TypeError
and ArgumentCountError.

Closes #24

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@kojiromike kojiromike merged commit 917c70d into main Jan 17, 2026
7 checks passed
@kojiromike kojiromike deleted the throwable branch January 17, 2026 04:50
@github-actions github-actions bot mentioned this pull request Jan 17, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: catch Throwable instead of Exception

2 participants

@kojiromike