fix(ImportCodesCommand): only check supported_external_dataloads for ICD types #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ICD types The --allow-unsupported feature was incorrectly requiring all code types to be found in the supported_external_dataloads table. However, only ICD9 and ICD10 use that table for validation. Other types (RXNORM, SNOMED, CQM_VALUESET) are validated purely by filename pattern matching and never populate from_database=true. This caused supported files like CQM valuesets to fail with "File not in supported_external_dataloads table" unless --allow-unsupported was used. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
--allow-unsupported- should succeed--allow-unsupported- should fail with suggestion--allow-unsupported- should succeed🤖 Generated with Claude Code
AI Disclosure: Yes