Skip to content

test#374

Closed
robertpietzcker wants to merge 10 commits intoopenENTRANCE:mainfrom
robertpietzcker:main
Closed

test#374
robertpietzcker wants to merge 10 commits intoopenENTRANCE:mainfrom
robertpietzcker:main

Conversation

@robertpietzcker
Copy link
Collaborator

@robertpietzcker robertpietzcker commented Jul 23, 2025

  • add a "supply" subcategory
  • shift "electricity" under this "supply" subcategory
  • add a split into "fuel cost", "investments" and "operation and maintenance cost"

@robertpietzcker robertpietzcker marked this pull request as draft July 23, 2025 15:36
@robertpietzcker robertpietzcker marked this pull request as ready for review July 23, 2025 15:42
@robertpietzcker
Copy link
Collaborator Author

@danielhuppmann @phackstock the checks are failing, but they are complaining about stuff that doesn't seem to be linked to my PR:

 ValueError: Collected 16 errors:
  1. Illegal character(s) ':' in source of region 'Norway|Ostland'.
  2. Illegal character(s) ':' in source of region 'Norway|Sorost'.
  3. Illegal character(s) ':' in source of region 'Norway|Hallingdal'.
  4. Illegal character(s) ':' in source of region 'Norway|Telemark'.
  5. Illegal character(s) ':' in source of region 'Norway|Sorland'.
  6. Illegal character(s) ':' in source of region 'Norway|Vestsyd'.
  7. Illegal character(s) ':' in source of region 'Norway|Vestmidt'.
  8. Illegal character(s) ':' in source of region 'Norway|Norgemidt'.
  9. Illegal character(s) ':' in source of region 'Norway|Helgeland'.
  10. Illegal character(s) ':' in source of region 'Norway|Troms'.
  11. Illegal character(s) ':' in source of region 'Norway|Finnmark'.
  12. Illegal character(s) ';' in notes of region 'Pan-Europe'.
  13. Illegal character(s) ':' in source of region 'EFTA'.
  14. Illegal character(s) ':' in source of region 'EU27 & EFTA'.
  15. Illegal character(s) ';' in note of region 'Italy|Subgrid north'.
  16. Illegal character(s) ';' in note of region 'Italy|Subgrid south'.

@danielhuppmann
Copy link
Member

We had a regression in nomenclature - this should have been fixed with release 0.25.1, not sure why this still persists here... Will investigate.

@danielhuppmann
Copy link
Member

Fixed via #375, please rebase.

Copy link
Collaborator

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@robertpietzcker
Copy link
Collaborator Author

thanks!

@danielhuppmann
Copy link
Member

Isn't this a duplicate of #376?

@robertpietzcker
Copy link
Collaborator Author

robertpietzcker commented Jul 29, 2025

yes.
apologies: I don't really know my way around git, and when I tried to rebase things sort of didn't go as I wanted, so I thought I do a "rebase by hand" by simply taking the head revision AFTER Daniel's quick fix, and then adding my commit on top of that.

but then I didn't close this PR here ...

@robertpietzcker
Copy link
Collaborator Author

so I would now simply close it.
Apologies, @phackstock , for making you review this one even though Daniel had already reviewed the other one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants