feat: implement dual-mode export with build tags separation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i#35) Signed-off-by: mikkeyf <1647228132@qq.com>
Signed-off-by: mikkeyf <1647228132@qq.com>
|
Related Documentation Checked 2 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Signed-off-by: mikkeyf <1647228132@qq.com>
Signed-off-by: mikkeyf <1647228132@qq.com>
Mikkey-f
changed the title
Signed-off-by: mikkeyf <1647228132@qq.com>
xuthus5
reviewed
Nov 16, 2025
cmd/subcmd/export_offline.go
Outdated
| @@ -1,3 +1,6 @@ | |||
| //go:build offline | |||
Member
There was a problem hiding this comment.
Move the build tag after the copyright information.
Signed-off-by: mikkeyf <1647228132@qq.com>
…de structure Signed-off-by: mikkeyf <1647228132@qq.com>
xuthus5
reviewed
Nov 24, 2025
cmd/subcmd/export_offline.go
Outdated
| "time" | ||
|
|
||
| "github.com/VictoriaMetrics/VictoriaMetrics/lib/encoding" | ||
| "github.com/golang/snappy" |
Member
There was a problem hiding this comment.
use github.com/klauspost/compress instead of github.com/golang/snappy
…t annotations Signed-off-by: mikkeyf <1647228132@qq.com>
Signed-off-by: mikkeyf <1647228132@qq.com>
xuthus5
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.