Skip to content

Conversation

@xkx9431
Copy link
Contributor

@xkx9431 xkx9431 commented Jan 11, 2025

Description

this PR is adding the compression support.

Changes

  1. add enum for compression method and content type
  2. add apply logic for modifying the http header before REST call, and process the response body according the http header config
  3. related tests

Validation

image

TodoList

  1. How should the changes for configuration be rolled out? For example, deprecate isGzipEnabled.

@xkx9431 xkx9431 changed the title @WIP feat(compress): add compress support for query response feat(compress): add compress support for query response Jan 11, 2025
@xkx9431 xkx9431 changed the title feat(compress): add compress support for query response @WIP feat(compress): add compress support for query response Jan 11, 2025
@xkx9431 xkx9431 changed the title @WIP feat(compress): add compress support for query response feat(compress): add compress support Jan 13, 2025
@xkx9431 xkx9431 force-pushed the xkx/compress branch 2 times, most recently from 1fedb7e to 4ad55f2 Compare January 13, 2025 14:04
@xkx9431 xkx9431 changed the title feat(compress): add compress support feat: add compress support Jan 16, 2025
@xkx9431 xkx9431 force-pushed the xkx/compress branch 2 times, most recently from 8bf081c to 48a8377 Compare January 18, 2025 03:33
@xkx9431 xkx9431 changed the title feat: add compress support feat: compress support Jan 18, 2025
@xkx9431 xkx9431 changed the title feat: compress support feat: compress support Jan 18, 2025
@xkx9431 xkx9431 changed the title feat: compress support @WIP feat: compress support Jan 18, 2025
@xkx9431 xkx9431 changed the title @WIP feat: compress support feat: compress support Jan 19, 2025
@xkx9431
Copy link
Contributor Author

xkx9431 commented Jan 19, 2025

@weiping-code @hezhangjian Please help review first.

"The tests pass consistently when configuring a single element in clientList. However, they fail randomly when using a List of clients for ParameterizedTest." Is there anything else you can help with?

@xiangyu5632
Copy link
Member

Does the server need to be configured to support data compression on the client? @xkx9431
As a result, your test cases fail.

Copy link
Member

@weiping-code weiping-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix according to the review comments and resolve the issues in the unit tests.

@xkx9431 xkx9431 force-pushed the xkx/compress branch 2 times, most recently from c7fbd48 to 8037b9a Compare March 8, 2025 02:34
Signed-off-by: kaixuan xu <[email protected]>
xkx9431 added 5 commits March 8, 2025 02:46
Signed-off-by: kaixuan xu <[email protected]>
Signed-off-by: kaixuan xu <[email protected]>
Signed-off-by: kaixuan xu <[email protected]>
Signed-off-by: kaixuan xu <[email protected]>
Signed-off-by: kaixuan xu <[email protected]>
@xkx9431 xkx9431 closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants