Lint: Use common wording for HTTP expectations in specs

Author: MrSerth

spec/controllers/bridges/lom/tasks_controller_spec.rb

@@ -16,7 +16,7 @@
     subject(:get_request) { get :show, params: {id: task.to_param} }
 
     shared_examples 'is a valid LOM response' do
-      it 'returns HTTP OK' do
+      it 'responds with status 200' do
         expect(response).to have_http_status :ok
       end
 
@@ -36,7 +36,7 @@
     context 'when not allowed to access the LOM' do
       let(:access_level) { :private }
 
-      it 'returns HTTP forbidden' do
+      it 'responds with status 403' do
         get_request
         expect(response).to have_http_status :forbidden
       end

spec/requests/collections_spec.rb

@@ -28,21 +28,21 @@
     end
 
     describe 'GET /collections/new' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get new_collection_path
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /collections/:id/edit' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get edit_collection_path(collection)
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /collection/:id' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get collection_path(collection)
         expect(response).to have_http_status(:ok)
       end

spec/requests/groups_spec.rb

@@ -28,21 +28,21 @@
     end
 
     describe 'GET /groups/new' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get new_group_path
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /groups/:id/edit' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get edit_group_path(group)
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /group/:id' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get group_path(group)
         expect(response).to have_http_status(:ok)
       end

spec/requests/tasks_spec.rb

@@ -44,21 +44,21 @@
     end
 
     describe 'GET /tasks/new' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get new_task_path
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /tasks/:id/edit' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get edit_task_path(task)
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /task/:id' do
-      it 'has http 200' do
+      it 'responds with status 200' do
         get task_path(task)
         expect(response).to have_http_status(:ok)
       end

spec/requests/users_spec.rb

@@ -30,14 +30,14 @@
     end
 
     describe 'GET /users/edit' do
-      it 'returns http 200' do
+      it 'responds with status 200' do
         get edit_user_registration_path
         expect(response).to have_http_status(:ok)
       end
     end
 
     describe 'GET /users/:id' do
-      it 'returns http 200' do
+      it 'responds with status 200' do
         get user_path(user)
         expect(response).to have_http_status(:ok)
       end