Skip to content

add mailer for collection invitations#2057

Merged
kkoehn merged 1 commit intomainfrom
1413-share-collection-notify-users-via-email
Aug 19, 2025
Merged

add mailer for collection invitations#2057
kkoehn merged 1 commit intomainfrom
1413-share-collection-notify-users-via-email

Conversation

@kkoehn
Copy link
Contributor

@kkoehn kkoehn commented Jul 1, 2025

fixes #1413

@kkoehn kkoehn self-assigned this Jul 1, 2025
@kkoehn kkoehn linked an issue Jul 1, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.77%. Comparing base (c6c9b0b) to head (e3ab947).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
+ Coverage   94.76%   94.77%   +0.01%     
==========================================
  Files         134      135       +1     
  Lines        3421     3429       +8     
==========================================
+ Hits         3242     3250       +8     
  Misses        179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kkoehn kkoehn force-pushed the 1413-share-collection-notify-users-via-email branch from 254d3b0 to 63f4c0e Compare July 2, 2025 19:02
@kkoehn kkoehn force-pushed the 1413-share-collection-notify-users-via-email branch 2 times, most recently from a786e43 to d49dc83 Compare July 23, 2025 19:39
@kkoehn kkoehn marked this pull request as ready for review August 5, 2025 18:06
@kkoehn kkoehn requested a review from arkirchner August 5, 2025 18:06
@arkirchner
Copy link
Contributor

I apologize for the late review!

@kkoehn kkoehn force-pushed the 1413-share-collection-notify-users-via-email branch from d49dc83 to e3ab947 Compare August 11, 2025 21:32
@kkoehn kkoehn requested a review from arkirchner August 13, 2025 19:04
@kkoehn kkoehn merged commit 13812ce into main Aug 19, 2025
15 checks passed
@kkoehn kkoehn deleted the 1413-share-collection-notify-users-via-email branch August 19, 2025 17:42
@MrSerth
Copy link
Member

MrSerth commented Aug 25, 2025

Thanks for working on this PR! Would you mind having a quick look at two bugs that are included? First, the mailer preview doesn't work currently (due to the mailer parametrization), and then, the text mail sent isn't correctly formatted.

Suggestion:

CollectionInvitationMailer.with(collection:, recipient: user).send_invitation
Preview Text Mail

@kkoehn
Copy link
Contributor Author

kkoehn commented Aug 25, 2025

@MrSerth thanks for noticing the bugs! I created a PR (#2133) to fix these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share collection: Notify users via email

3 participants