Lint: Use hash for data attributes in views

MrSerth · MrSerth · commit dc156e4dead7 · 2025-07-09T13:11:37.000+02:00
diff --git a/app/views/application/_navigation.html.slim b/app/views/application/_navigation.html.slim
@@ -6,8 +6,8 @@
         span.caret
       ul.dropdown-menu.p-0.mt-1 role='menu'
         - if current_user.admin?
-          li = link_to(t('breadcrumbs.dashboard.show'), admin_dashboard_path, class: 'dropdown-item', 'data-turbo': 'false') if policy(%i[admin dashboard]).show?
-          li = link_to(t('breadcrumbs.rails_admin.show'), rails_admin.dashboard_path, class: 'dropdown-item', 'data-turbo': 'false') if policy(%i[admin dashboard]).show?
+          li = link_to(t('breadcrumbs.dashboard.show'), admin_dashboard_path, class: 'dropdown-item', data: {turbo: false}) if policy(%i[admin dashboard]).show?
+          li = link_to(t('breadcrumbs.rails_admin.show'), rails_admin.dashboard_path, class: 'dropdown-item', data: {turbo: false}) if policy(%i[admin dashboard]).show?
           li = link_to(t('breadcrumbs.statistics.show'), statistics_path, class: 'dropdown-item') if policy(:statistics).show?
           li.dropdown-divider role='separator'
         = render('navigation_submenu', title: Exercise.model_name.human(count: :other),
diff --git a/app/views/codeharbor_links/_form.html.slim b/app/views/codeharbor_links/_form.html.slim
@@ -2,14 +2,14 @@
   = render('shared/form_errors', object: @codeharbor_link)
   .mb-3
     = f.label(:push_url, class: 'form-label')
-    = f.text_field :push_url, data: {'bs-toggle': 'tooltip', 'bs-placement': 'bottom'}, title: t('codeharbor_link.info.push_url'), class: 'form-control'
+    = f.text_field :push_url, data: {bs_toggle: 'tooltip', bs_placement: 'bottom'}, title: t('codeharbor_link.info.push_url'), class: 'form-control'
   .mb-3
     = f.label(:check_uuid_url, class: 'form-label')
-    = f.text_field :check_uuid_url, data: {'bs-toggle': 'tooltip', 'bs-placement': 'bottom'}, title: t('codeharbor_link.info.check_uuid_url'), class: 'form-control'
+    = f.text_field :check_uuid_url, data: {bs_toggle: 'tooltip', bs_placement: 'bottom'}, title: t('codeharbor_link.info.check_uuid_url'), class: 'form-control'
   .mb-3
     = f.label(:api_key, class: 'form-label')
     .input-group
-      = f.text_field(:api_key, data: {'bs-toggle': 'tooltip', 'bs-placement': 'bottom'}, title: t('codeharbor_link.info.api_key'), class: 'form-control api_key')
+      = f.text_field(:api_key, data: {bs_toggle: 'tooltip', bs_placement: 'bottom'}, title: t('codeharbor_link.info.api_key'), class: 'form-control api_key')
       .input-group-btn
         = button_tag(t('codeharbor_link.generate'), type: 'button', class: 'generate-api_key btn btn-default')
   .actions
diff --git a/app/views/execution_environments/show.html.slim b/app/views/execution_environments/show.html.slim
@@ -5,7 +5,7 @@ h1.d-inline-block = @execution_environment
   ul.dropdown-menu.dropdown-menu-end role='menu'
     li = button_to(t('execution_environments.index.synchronize.button'), sync_to_runner_management_execution_environment_path(@execution_environment), method: :post, class: 'dropdown-item') if policy(@execution_environment).sync_to_runner_management?
     li = link_to(t('execution_environments.index.shell'), shell_execution_environment_path(@execution_environment), class: 'dropdown-item') if policy(@execution_environment).shell?
-    li = link_to(t('shared.statistics'), statistics_execution_environment_path(@execution_environment), 'data-turbo': 'false', class: 'dropdown-item') if policy(@execution_environment).statistics?
+    li = link_to(t('shared.statistics'), statistics_execution_environment_path(@execution_environment), data: {turbo: false}, class: 'dropdown-item') if policy(@execution_environment).statistics?
     li = button_to(t('shared.destroy'), @execution_environment, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(@execution_environment).destroy?
 
 = row(label: 'execution_environment.name', value: @execution_environment.name)
diff --git a/app/views/execution_environments/statistics.html.slim b/app/views/execution_environments/statistics.html.slim
@@ -21,7 +21,7 @@ h1 = @execution_environment
         - if wts then average_time = wts['average_time'] else 0 # rubocop:disable Lint/ElseLayout
         - if wts then stddev_time = wts['stddev_time'] else 0 # rubocop:disable Lint/ElseLayout
         tr
-          td = link_to_if(policy(exercise).statistics?, exercise.title, controller: 'exercises', action: 'statistics', id: exercise.id, 'data-turbo': 'false')
+          td = link_to_if(policy(exercise).statistics?, exercise.title, controller: 'exercises', action: 'statistics', id: exercise.id, data: {turbo: false})
           td = us['contributors']
           td = us['average_score'].to_f.round(4)
           td = us['maximum_score'].to_f.round(2)
diff --git a/app/views/exercise_collections/_form.html.slim b/app/views/exercise_collections/_form.html.slim
@@ -24,7 +24,7 @@
             td
               span.fa-solid.fa-bars
             td = item.exercise.title
-            td = link_to(t('shared.show'), item.exercise, 'data-turbo': 'false')
+            td = link_to(t('shared.show'), item.exercise, data: {turbo: false})
             td
               a.remove-exercise href='#' = t('shared.destroy')
   .d-none
diff --git a/app/views/exercise_collections/show.html.slim b/app/views/exercise_collections/show.html.slim
@@ -25,4 +25,4 @@ h4.mt-4 = ExerciseCollection.human_attribute_name('exercises')
           td = link_to_if(policy(exercise).show?, exercise.title, exercise)
           td = link_to_if(exercise.execution_environment && policy(exercise.execution_environment).show?, exercise.execution_environment, exercise.execution_environment)
           td = link_to_if(exercise.user && policy(exercise.user).show?, exercise.user.displayname, exercise.user)
-          td = link_to(t('shared.statistics'), statistics_exercise_path(exercise), 'data-turbo': 'false') if policy(exercise).statistics?
+          td = link_to(t('shared.statistics'), statistics_exercise_path(exercise), data: {turbo: false}) if policy(exercise).statistics?
diff --git a/app/views/exercise_collections/statistics.html.slim b/app/views/exercise_collections/statistics.html.slim
@@ -48,4 +48,4 @@ h4.mt-4 = ExerciseCollection.human_attribute_name('exercises')
           td = exercise.submissions.send(:final).distinct.count(:contributor_id)
           td = exercise.finishers_percentage
           td = exercise.average_percentage
-          td = link_to(t('shared.statistics'), statistics_exercise_path(exercise), 'data-turbo': 'false') if policy(exercise).statistics?
+          td = link_to(t('shared.statistics'), statistics_exercise_path(exercise), data: {turbo: false}) if policy(exercise).statistics?
diff --git a/app/views/exercises/_import_actions.html.slim b/app/views/exercises/_import_actions.html.slim
@@ -1,14 +1,14 @@
 - if imported
   = link_to(t('exercises.import_proforma.button.show_exercise'), exercise, class: 'btn btn-light btn-sm float-end show-action import-export-button', target: '_blank', rel: 'noopener noreferrer')
 - elsif exists && updatable
-  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'import', 'file-id' => file_id}) do
+  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {import_type: 'import', file_id: file_id}) do
     i.fa-solid.fa-check.confirm-icon.export-button-icon
     = t('exercises.import_proforma.button.overwrite')
 - elsif exists
-  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'create_new', 'file-id' => file_id}) do
+  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {import_type: 'create_new', file_id: file_id}) do
     i.fa-solid.fa-check.confirm-icon-alt.export-button-icon
     = t('exercises.import_proforma.button.import_copy')
 - else
-  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {'import-type' => 'import', 'file-id' => file_id}) do
+  = button_tag(type: 'button', class: 'btn btn-success btn-sm float-end import-action import-export-button', data: {import_type: 'import', file_id: file_id}) do
     i.fa-solid.fa-check.confirm-icon.export-button-icon
     = t('exercises.import_proforma.button.import')
diff --git a/app/views/exercises/index.html.slim b/app/views/exercises/index.html.slim
@@ -22,13 +22,13 @@ h1 = Exercise.model_name.human(count: :other)
           = Exercise.human_attribute_name('public')
           - if policy(Exercise).batch_update?
             br
-            span.batch = link_to(t('shared.batch_update'), '#', 'data-text': t('shared.update', model: Exercise.model_name.human(count: :other)))
+            span.batch = link_to(t('shared.batch_update'), '#', data: {text: t('shared.update', model: Exercise.model_name.human(count: :other))})
         th.p-1 colspan=6 = t('shared.actions')
     tbody
       - @exercises.each do |exercise|
         tr data-id=exercise.id
           td.p-1.pt-2
-            = link_to_if(policy(exercise).show?, exercise.title, exercise, 'data-turbo': 'false')
+            = link_to_if(policy(exercise).show?, exercise.title, exercise, data: {turbo: false})
             - if exercise.internal_title.present?
               p.mb-0.text-muted
                 i.fa-solid.fa-arrow-turn-up.fa-rotate-90
@@ -41,19 +41,19 @@ h1 = Exercise.model_name.human(count: :other)
           td.p-1.pt-2.public data-value=exercise.public? = symbol_for(exercise.public?)
           td.p-1.pt-2 = link_to(t('shared.edit'), edit_exercise_path(exercise)) if policy(exercise).edit?
           td.p-1.pt-2 = link_to(t('.implement'), implement_exercise_path(exercise)) if policy(exercise).implement?
-          td.p-1.pt-2 = link_to(t('shared.statistics'), statistics_exercise_path(exercise), 'data-turbo': 'false') if policy(exercise).statistics?
+          td.p-1.pt-2 = link_to(t('shared.statistics'), statistics_exercise_path(exercise), data: {turbo: false}) if policy(exercise).statistics?
 
           td.p-1
             .btn-group
               button.btn.btn-outline-primary.btn-sm.dropdown-toggle data-bs-toggle='dropdown' type='button' = t('shared.actions_button')
               ul.dropdown-menu.float-end role='menu'
-                li = link_to(t('shared.show'), exercise, 'data-turbo': 'false', class: 'dropdown-item') if policy(exercise).show?
+                li = link_to(t('shared.show'), exercise, data: {turbo: false}, class: 'dropdown-item') if policy(exercise).show?
                 li = link_to(UserExerciseFeedback.model_name.human(count: :other), feedback_exercise_path(exercise), class: 'dropdown-item') if policy(exercise).feedback?
                 li = link_to(RequestForComment.model_name.human(count: :other), exercise_request_for_comments_path(exercise), class: 'dropdown-item') if policy(exercise).rfcs_for_exercise?
                 li = link_to(ProgrammingGroup.model_name.human(count: :other), exercise_programming_groups_path(exercise), class: 'dropdown-item') if policy(exercise).programming_groups_for_exercise?
                 li = button_to(t('shared.destroy'), exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(exercise).destroy?
                 li = button_to(t('.clone'), clone_exercise_path(exercise), data: {confirm: t('shared.confirm_destroy'), turbo: false}, method: :post, class: 'dropdown-item') if policy(exercise).clone?
-                li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {'exercise-id': exercise.id, 'bs-toggle': 'modal', 'bs-target': '#transfer-modal'}) if policy(exercise).export_external_confirm?
+                li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {exercise_id: exercise.id, bs_toggle: 'modal', bs_target: '#transfer-modal'}) if policy(exercise).export_external_confirm?
                 li = link_to(t('exercises.download_proforma.label'), download_proforma_exercise_path(exercise), class: 'dropdown-item', target: '_blank', rel: 'noopener noreferrer') if policy(exercise).download_proforma?
 
 = render('shared/pagination', collection: @exercises)
diff --git a/app/views/exercises/show.html.slim b/app/views/exercises/show.html.slim
@@ -13,13 +13,13 @@ h1.d-inline-block
   button.btn.btn-secondary.float-end.dropdown-toggle data-bs-toggle='dropdown' type='button'
   ul.dropdown-menu.dropdown-menu-end role='menu'
     li = link_to(t('exercises.index.implement'), implement_exercise_path(@exercise), class: 'dropdown-item') if policy(@exercise).implement?
-    li = link_to(t('shared.statistics'), statistics_exercise_path(@exercise), 'data-turbo': 'false', class: 'dropdown-item') if policy(@exercise).statistics?
+    li = link_to(t('shared.statistics'), statistics_exercise_path(@exercise), data: {turbo: false}, class: 'dropdown-item') if policy(@exercise).statistics?
     li = link_to(UserExerciseFeedback.model_name.human(count: :other), feedback_exercise_path(@exercise), class: 'dropdown-item') if policy(@exercise).feedback?
     li = link_to(RequestForComment.model_name.human(count: :other), exercise_request_for_comments_path(@exercise), class: 'dropdown-item') if policy(@exercise).rfcs_for_exercise?
     li = link_to(ProgrammingGroup.model_name.human(count: :other), exercise_programming_groups_path(@exercise), class: 'dropdown-item') if policy(@exercise).programming_groups_for_exercise?
     li = button_to(t('shared.destroy'), @exercise, data: {confirm: t('shared.confirm_destroy')}, method: :delete, class: 'dropdown-item') if policy(@exercise).destroy?
     li = button_to(t('exercises.index.clone'), clone_exercise_path(@exercise), data: {confirm: t('shared.confirm_destroy')}, method: :post, class: 'dropdown-item') if policy(@exercise).clone?
-    li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {'exercise-id': @exercise.id, 'bs-toggle': 'modal', 'bs-target': '#transfer-modal'}) if policy(@exercise).export_external_confirm?
+    li = link_to(t('exercises.export_codeharbor.label'), '', class: 'dropdown-item export-start', data: {exercise_id: @exercise.id, bs_toggle: 'modal', bs_target: '#transfer-modal'}) if policy(@exercise).export_external_confirm?
     li = link_to(t('exercises.download_proforma.label'), download_proforma_exercise_path(@exercise), class: 'dropdown-item', target: '_blank', rel: 'noopener noreferrer') if policy(@exercise).download_proforma?
 
 = row(label: 'exercise.title', value: @exercise.title)
diff --git a/app/views/layouts/application.html.slim b/app/views/layouts/application.html.slim
@@ -12,11 +12,11 @@ html lang=I18n.locale data-default-locale=I18n.default_locale
     = favicon_link_tag('/icon.png', rel: 'apple-touch-icon', type: 'image/png')
     = tag.link rel: 'manifest', href: pwa_manifest_path
     = action_cable_meta_tag
-    = stylesheet_pack_tag('application', 'stylesheets', "multilang_#{I18n.locale}", media: 'all', 'data-turbo-track': 'reload', integrity: true, crossorigin: 'anonymous')
-    = stylesheet_link_tag('application', media: 'all', 'data-turbo-track': 'reload', integrity: true, crossorigin: 'anonymous')
+    = stylesheet_pack_tag('application', 'stylesheets', "multilang_#{I18n.locale}", media: 'all', data: {turbo_track: 'reload'}, integrity: true, crossorigin: 'anonymous')
+    = stylesheet_link_tag('application', media: 'all', data: {turbo_track: 'reload'}, integrity: true, crossorigin: 'anonymous')
     // Since d3-tip is loaded via a separate pack and requires the application pack to be loaded first, we cannot use `defer` here.
-    = javascript_pack_tag('application', 'data-turbo-track': 'reload', defer: false, integrity: true, crossorigin: 'anonymous')
-    = javascript_include_tag('application', 'data-turbo-track': 'reload', defer: true, integrity: true, crossorigin: 'anonymous')
+    = javascript_pack_tag('application', data: {turbo_track: 'reload'}, defer: false, integrity: true, crossorigin: 'anonymous')
+    = javascript_include_tag('application', data: {turbo_track: 'reload'}, defer: true, integrity: true, crossorigin: 'anonymous')
     = yield(:head)
     = csrf_meta_tags
     /= csp_meta_tag
@@ -39,7 +39,7 @@ html lang=I18n.locale data-default-locale=I18n.default_locale
             ul.nav.navbar-nav.ms-auto
               = render('color_mode_selector', cached: true)
               = render('locale_selector', cached: true)
-              li.nav-item.me-3 = link_to(t('shared.help.link'), '#modal-help', data: {'bs-toggle': 'modal'}, class: 'nav-link')
+              li.nav-item.me-3 = link_to(t('shared.help.link'), '#modal-help', data: {bs_toggle: 'modal'}, class: 'nav-link')
               = render('session')
     div data-controller=controller_name
       = render('flash')
diff --git a/app/views/programming_groups/index.html.slim b/app/views/programming_groups/index.html.slim
@@ -30,7 +30,7 @@
         tr
           td = link_to_if(policy(programming_group).show?, programming_group.displayname, programming_group)
           - if @exercise.nil?
-            td = link_to_if(policy(programming_group.exercise).show?, programming_group.exercise.title, programming_group.exercise, 'data-turbo': 'false')
+            td = link_to_if(policy(programming_group.exercise).show?, programming_group.exercise.title, programming_group.exercise, data: {turbo: false})
           td == programming_group.users.map {|user| link_to_if(policy(user).show?, user.name, user) }.join(', ')
           td = programming_group.users.size
           td = l(programming_group.created_at, format: :short)
diff --git a/app/views/request_for_comments/index.html.slim b/app/views/request_for_comments/index.html.slim
@@ -15,7 +15,7 @@ h1 = RequestForComment.model_name.human(count: :other)
         .col
           = f.label(:submission_study_group_id_eq, t('request_for_comments.index.study_groups.placeholder'), class: 'visually-hidden form-label')
           = f.grouped_collection_select(:submission_study_group_id_in, @study_groups_grouping, :second, :first, :id, :to_s, {},
-                  {class: 'form-control', multiple: true, 'data-placeholder': t('request_for_comments.index.study_groups.placeholder')})
+                  {class: 'form-control', multiple: true, data: {placeholder: t('request_for_comments.index.study_groups.placeholder')}})
 
 .table-responsive
   table.table.mt-4 class=(@request_for_comments.present? ? 'sortable' : '')
