Merged
Conversation
Rubocop gives valuable information about issues in migration. New migrations should be checked by the linter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3045 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 215 215
Lines 6850 6850
=======================================
Hits 4801 4801
Misses 2049 2049 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkoehn
approved these changes
Jul 29, 2025
Contributor
kkoehn
left a comment
There was a problem hiding this comment.
This is great, I didn't know this existed!
Member
|
@arkirchner Could you please apply the same changes in CodeHarbor, since the Rubocop configuration is closely set in both projects? |
Member
|
Thanks for adding similar changes in CodeHarbor with openHPI/codeharbor#2092. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rubocop gives valuable information about issues in migration. New migrations should be checked by the linter.