Skip to content
This repository was archived by the owner on Apr 30, 2022. It is now read-only.

Update dependencies, miscellaneuous usability improvements #114

Open
richardebeling wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Update dependencies, miscellaneuous usability improvements #114

richardebeling wants to merge 26 commits into from

Conversation

@richardebeling
Copy link
Contributor

@richardebeling richardebeling commented Nov 15, 2019 •
edited
Loading

  • Update dependencies. I couldn't get any higher version of the rollup plugins to work, I think it might be related to incompatibility with higher rollup versions, but I'm not sure (gulp-rollup hasn't been updated for 2 years)
  • Improve the sliders (used for video progress and volume setting): Allow dragging and dropping. This was super annoying before. Fixes Let progress bar be changeable via Drag'n'Drop #23
  • Use buttons where it's semantically correct. This prevents the href previews being shown by the browser. The code also suppresses the keyboard focus being set to the clicked element. Before, when clicking the play button, you could not use the space key for pausing / unpausing anymore as it triggered the button as well as the hard-coded play-state change -> the video paused and then unpaused again.

he3lixxx added 26 commits November 6, 2019 14:31
@he3lixxx
Update dependencies.
361ea08 
The following packages caused issues, so I didn't update them (yet):
babel-preset-es2015 (should be repalces by @babel/preset-env ?)
gulp-babel
rollup-plugin-commonjd
rollup-plugin-node-resolve
@he3lixxx
Fix node-resolve deprecation warning in bundle
abda3ef
@he3lixxx
Update devDependencides: babel, gulp-babel and babel-preset-es2015 (r…
5e83e99 
…eplaced by @babel/preset-env)
@he3lixxx
More minor updates, fix missing packages, remove unused packages. Rol…
e456851 
…lup major update todo.
@he3lixxx
Semantically use button tags
3287409 
Use buttons instead of <a href="javascript:void(0)"> when appropriate

This fixes two problems: When hovering buttons, earlier, browsers would
show the href destination with a little pop up on a corner of the
screen. Also, these elements would get the keyboard focus if clicked.
This is now solved.
@he3lixxx
Allow dragging the slider in the progress bars.
0415f8e 
Users can now drag-and-drop the volume as well as the position sliders.
@he3lixxx
Fix playlist-chapter-list-switch test querying for anchor instead of …
876f6f6 
…button
@he3lixxx
Prevent long loading queue when dragging the video position slider. Y…
85ccfbf 
…ouTube does this similarly, but they also pause the video and show the thumbnail images in the video frame. This solution is a bit simpler, but can be extended to what YouTube does.
@he3lixxx
Update player position when url hash fragment changes
bf1088e
@he3lixxx
Linting fixes
a6a315e
@he3lixxx
Allow specifying custom playback rates in the player configuration
b2ffe33
@he3lixxx
Node 15
e8aa04e
@he3lixxx
Update dependencies where it works out of the box. HLS and rollup TODO
3a8ca11
@he3lixxx
Drop ie11 support for better and faster builds
24e1f1f 
gulp-rollup seem to be abandoned and depends on rollup 0.68.  However,
the current version is rollup 2. This disallowed for updating the
plugins.

If we just remove IE11 support, we can extremely simplify our build
process by completely removing gulp and just directly calling rollup.
This increases build speed by factor 3 while it allows for better
minification, reducing file size by 50%.

IE11 was broken on teleTASK any way and openHPI does not support IE11
anymore, so this should not break anything.

As a side effect, we have 15 less dev dependencies, which should make
maintenance easier.
@he3lixxx
Update hls.js
feb2627
@he3lixxx
npm audit fix
4e5576a
@he3lixxx
Save and restore quizOverlayEnabled state in local storage
9f030bb
@he3lixxx
Fix accidentally in-place reordered playback rates
953c8c9
@he3lixxx
Add new keyboard shortcuts
98aa21b 
ArrowUp / ArrowDown for volume changes (5% steps)
m for "mute"
<> and ;: for faster / slower
@he3lixxx
Keyboard shortcut: Allow skipping by frame using , and .
515710e
@he3lixxx
Fix jumping back a few frames on pause
e8603e5
@he3lixxx
Fix linting errors
fbbaedb
@he3lixxx
Prevent changing of video playback position when editing notes
e94308c
@he3lixxx
Update dependencies
65dea64
@he3lixxx
Update hls.js
2362218
@he3lixxx
npm audit fix
836f848
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Let progress bar be changeable via Drag'n'Drop

2 participants

@richardebeling @he3lixxx