FINERACT: Refactor arrears SQL concatenation to use PreparedStatements#193
Closed
shubhamchaudhary29 wants to merge 2 commits intoopenMF:developfrom
Closed
FINERACT: Refactor arrears SQL concatenation to use PreparedStatements#193shubhamchaudhary29 wants to merge 2 commits intoopenMF:developfrom
shubhamchaudhary29 wants to merge 2 commits intoopenMF:developfrom
Conversation
Replaced raw string concatenation in LoanArrearsAgingServiceImpl with parameterized queries to prevent SQL injection and enable JDBC execution plan caching for batch jobs.
Collaborator
|
@shubhamchaudhary29 Should this be targeting apache repo instead, no? |
Author
Sorry adam, realised my mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced raw string concatenation in LoanArrearsAgingServiceImpl with parameterized queries to prevent SQL injection and enable JDBC execution plan caching for batch jobs.
Relying on string concatenation for SQL queries inside a batch job is a standard security anti-pattern, but more importantly, it bypasses JDBC execution plan caching. This creates an unnecessary performance bottleneck on the database engine when updating thousands of overdue loans.
Changes Made: