fix - Language Inconsistency in Transfer Details Screen#3103
fix - Language Inconsistency in Transfer Details Screen#3103biplab1 merged 7 commits intoopenMF:developmentfrom
Conversation
📝 WalkthroughWalkthroughAdds ~37 new localization XML resource files across core UI and two features, providing translations for multiple locales (bn, fa, km, my, pl, ru, te, ur, ar, fr, hi, in, kn, pt, sw) with UI labels, validation messages, and transfer-related strings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@core/ui/src/commonMain/composeResources/values-ur/strings.xml`:
- Line 48: The Urdu string for validation_email_max_length_exceeded has a
duplicated word "ای ای میل"; update the value of the string resource named
validation_email_max_length_exceeded to use the correct phrase "ای میل ایڈریس کی
لمبائی 254 حروف سے زیادہ ہے" (remove the extra "ای") so the translation reads
correctly.
In
`@feature/transfer-process/src/commonMain/composeResources/values-in/strings.xml`:
- Around line 1-38: The resource directory is incorrectly named values-in for
Indonesian in the Compose Multiplatform resources; rename the directory from
values-in to values-id so Compose Multiplatform (commonMain/composeResources)
uses the ISO 639-1 code, and move or update any references to the string bundle
(the XML containing strings like "transfer", "transferred_successfully", etc.)
to the new values-id directory to ensure proper localization resolution.
In
`@feature/transfer-process/src/commonMain/composeResources/values-kn/strings.xml`:
- Line 27: The string value for key "back_to_accounts" in values-kn/strings.xml
appears to mean "Return to Home Screen" rather than "back to accounts"; review
the intent of the "back_to_accounts" resource (compare other locale files for
the same key) and update the Kannada translation to match that intent (e.g.,
change to a phrase meaning "Return to Accounts" if the UI goes back to an
accounts view) while keeping the resource name "back_to_accounts" unchanged;
also ensure consistency with other locales and surrounding UI copy.
feature/transfer-process/src/commonMain/composeResources/values-in/strings.xml
Show resolved
Hide resolved
feature/transfer-process/src/commonMain/composeResources/values-kn/strings.xml
Outdated
Show resolved
Hide resolved
|
@Aryan-Baglane please update the branch |
Fixes - MM-509
Fix - Language Incosistency in Transfer Detail Screen
Screen.Recording.2026-02-12.at.11.26.08.PM.mov
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
Summary by CodeRabbit