Skip to content

fix - Language Inconsistency in Transfer Details Screen#3103

Merged
biplab1 merged 7 commits intoopenMF:developmentfrom
Aryan-Baglane:LanguageConsitency-TransferScreen
Feb 12, 2026
Merged

fix - Language Inconsistency in Transfer Details Screen#3103
biplab1 merged 7 commits intoopenMF:developmentfrom
Aryan-Baglane:LanguageConsitency-TransferScreen

Conversation

@Aryan-Baglane
Copy link
Contributor

@Aryan-Baglane Aryan-Baglane commented Feb 3, 2026

Fixes - MM-509
Fix - Language Incosistency in Transfer Detail Screen

Screen.Recording.2026-02-12.at.11.26.08.PM.mov

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

  • Chores
    • Added comprehensive localization for core UI and transfer workflows in 15+ languages (Bengali, Persian, Khmer, Burmese, Polish, Russian, Telugu, Urdu, Arabic, French, Hindi, Indonesian, Kannada, Portuguese, Swahili), enabling localized UI labels, validation messages, error text and transfer feature strings for end users.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Adds ~37 new localization XML resource files across core UI and two features, providing translations for multiple locales (bn, fa, km, my, pl, ru, te, ur, ar, fr, hi, in, kn, pt, sw) with UI labels, validation messages, and transfer-related strings.

Changes

Cohort / File(s) Summary
Core UI localization
core/ui/src/commonMain/composeResources/values-{bn,fa,km,my,pl,ru,te,ur}/strings.xml
Added 8 locale-specific strings.xml files (~100–136 entries each) containing connectivity text, validation messages (password, email, phone/name), password strength feedback, balance/dashboard/savings labels, and formatted placeholders.
Third‑party transfer localization
feature/third-party-transfer/src/commonMain/composeResources/values-{ar,bn,fa,fr,hi,in,km,kn,my,pl,pt,ru,sw,te,ur}/strings.xml
Added 15 locale-specific strings.xml files (~14 entries each) defining feature_tpt_* keys for amount/remarks validation, origin/destination account labels, tips, and transfer button text.
Transfer‑process localization
feature/transfer-process/src/commonMain/composeResources/values-{ar,bn,fa,fr,hi,in,km,kn,my,pl,pt,ru,sw,te,ur}/strings.xml
Added 15 locale-specific strings.xml files (~24–40 entries each) with transfer flow strings: labels, success/failure messages, validation errors, transfer ID prefix, and field descriptors (feature_make_transfer_* keys).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • itsPronay
  • Nagarjuna0033

Poem

🐰 I hop through folders, one locale at a time,
Bengali, Farsi, Khmer — each string gets a rhyme.
Transfer tips and balances, in languages anew,
Carrots of text for every user to view. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly indicates the purpose of fixing language inconsistency in the Transfer Details screen, which is the primary focus of all the changes (adding/correcting translations across multiple locales).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In `@core/ui/src/commonMain/composeResources/values-ur/strings.xml`:
- Line 48: The Urdu string for validation_email_max_length_exceeded has a
duplicated word "ای ای میل"; update the value of the string resource named
validation_email_max_length_exceeded to use the correct phrase "ای میل ایڈریس کی
لمبائی 254 حروف سے زیادہ ہے" (remove the extra "ای") so the translation reads
correctly.

In
`@feature/transfer-process/src/commonMain/composeResources/values-in/strings.xml`:
- Around line 1-38: The resource directory is incorrectly named values-in for
Indonesian in the Compose Multiplatform resources; rename the directory from
values-in to values-id so Compose Multiplatform (commonMain/composeResources)
uses the ISO 639-1 code, and move or update any references to the string bundle
(the XML containing strings like "transfer", "transferred_successfully", etc.)
to the new values-id directory to ensure proper localization resolution.

In
`@feature/transfer-process/src/commonMain/composeResources/values-kn/strings.xml`:
- Line 27: The string value for key "back_to_accounts" in values-kn/strings.xml
appears to mean "Return to Home Screen" rather than "back to accounts"; review
the intent of the "back_to_accounts" resource (compare other locale files for
the same key) and update the Kannada translation to match that intent (e.g.,
change to a phrase meaning "Return to Accounts" if the UI goes back to an
accounts view) while keeping the resource name "back_to_accounts" unchanged;
also ensure consistency with other locales and surrounding UI copy.

@itsPronay
Copy link
Contributor

@Aryan-Baglane please update the branch

Copy link
Contributor

@markrizkalla markrizkalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ar LGTM

Copy link
Contributor

@mena-rizkalla mena-rizkalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values ar LGTM

@biplab1 biplab1 enabled auto-merge (squash) February 12, 2026 18:03
@biplab1 biplab1 merged commit 3465aee into openMF:development Feb 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants