-
Notifications
You must be signed in to change notification settings - Fork 800
WEB-340 replace custom api of saving.service.ts #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: openapi-integration
Are you sure you want to change the base?
WEB-340 replace custom api of saving.service.ts #2713
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@gkbishnoi07 Please Review |
|
Okay |
|
@gkbishnoi07 , I assume that your comment means that you are still reviewing this? I don't want to appear pushy - just want to make sure I understand your comment. |
gkbishnoi07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test your PR first
402472b to
f087bcc
Compare
|
@gkbishnoi07 I have update the PR please review . |
gkbishnoi07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Replaced custom methods in *.ts files that were previously using SavingService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.