-
Notifications
You must be signed in to change notification settings - Fork 800
WEB-379 replace custom api of system.service.ts #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: openapi-integration
Are you sure you want to change the base?
WEB-379 replace custom api of system.service.ts #2796
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note
|
|
@gkbishnoi07 @steinwinde Please Review |
gkbishnoi07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check all video
system.mp4
system-3.mp4 |
system-4.mp4 |
ae713b6 to
4f8318c
Compare
|
@gkbishnoi07 I have update the PR please review |
|
ok |
gkbishnoi07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
messaged on slack please fix it
Replaced custom methods in *.ts files that were previously using SystemService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package .
WEB-379