Skip to content

Conversation

@JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented Nov 12, 2025

Replaced custom methods in *.ts files that were previously using SystemService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package .

WEB-379

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JaySoni1
Copy link
Contributor Author

JaySoni1 commented Nov 12, 2025

@gkbishnoi07 @steinwinde Please Review

@gkbishnoi07 gkbishnoi07 self-requested a review November 21, 2025 20:49
Copy link
Collaborator

@gkbishnoi07 gkbishnoi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check all video

system.mp4

@gkbishnoi07
Copy link
Collaborator

system-3.mp4

@gkbishnoi07
Copy link
Collaborator

system-4.mp4

@JaySoni1 JaySoni1 force-pushed the WEB-379-replace-custom-api-of-system-service-ts branch from ae713b6 to 4f8318c Compare November 22, 2025 21:31
@JaySoni1
Copy link
Contributor Author

@gkbishnoi07 I have update the PR please review

@JaySoni1 JaySoni1 requested a review from gkbishnoi07 November 23, 2025 09:18
@gkbishnoi07
Copy link
Collaborator

ok

Copy link
Collaborator

@gkbishnoi07 gkbishnoi07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

messaged on slack please fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants