WEB-489-fix/add-missing-translation-keys #2875
Conversation
|
Warning Rate limit exceeded@shubhamkumar9199 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 47 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (13)
Note
|
| Cohort / File(s) | Summary |
|---|---|
Translation files src/assets/translations/cs-CS.json, src/assets/translations/de-DE.json, src/assets/translations/en-US.json, src/assets/translations/es-CL.json, src/assets/translations/es-MX.json, src/assets/translations/fr-FR.json, src/assets/translations/it-IT.json, src/assets/translations/ko-KO.json, src/assets/translations/lt-LT.json, src/assets/translations/lv-LV.json, src/assets/translations/ne-NE.json, src/assets/translations/pt-PT.json, src/assets/translations/sw-SW.json |
Added translation keys across locales (examples: Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier). Some occurrences of Savings Account Details were removed or relocated across contexts (labels, catalogs, menus, inputs). |
Template translation key update src/app/accounting/closing-entries/view-closure/view-closure.component.html |
Updated translation key usage from 'labels.inputs.Updated On' to 'labels.inputs.Updated on' (no data-binding or logic changes). |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
- Verify consistent key spelling/casing across all locale files.
- Confirm
Savings Account Detailsrelocation is intentional and references align with templates. - Spot-check a few locales for encoding or obvious typos.
Possibly related PRs
- WEB-478-fix/i18n/savings-account-details-missing #2856 — modifies the same translation keys/locales, including
Savings Account Details. - WEB-491 :- fix labels.inputs.Updated On to labels.inputs.Updated on #2871 — updates the same template translation key in
view-closure.component.html. - WEB-481 :- a translation problem in mifos home page Tooltip text shows tooltips.Collection Sheet instead of Collection Sheet #2863 — adjusts usages of
Collection Sheettranslation keys and related UI references.
Suggested reviewers
- gkbishnoi07
- IOhacker
- alberto-art3ch
Pre-merge checks and finishing touches
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'WEB-489-fix/add-missing-translation-keys' clearly describes the main change: adding missing translation keys across language files as referenced in issue WEB-489. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/assets/translations/cs-CS.json(9 hunks)src/assets/translations/de-DE.json(9 hunks)src/assets/translations/en-US.json(9 hunks)src/assets/translations/es-CL.json(9 hunks)src/assets/translations/es-MX.json(9 hunks)src/assets/translations/fr-FR.json(10 hunks)src/assets/translations/it-IT.json(9 hunks)src/assets/translations/ko-KO.json(9 hunks)src/assets/translations/lt-LT.json(9 hunks)src/assets/translations/lv-LV.json(9 hunks)src/assets/translations/ne-NE.json(9 hunks)src/assets/translations/pt-PT.json(9 hunks)src/assets/translations/sw-SW.json(9 hunks)
🔇 Additional comments (40)
src/assets/translations/de-DE.json (1)
2778-2778: Translation additions are well-formed and properly placed; note one translation inconsistency.The new translation keys are correctly added to the
textsection with appropriate German translations. However, there's a subtle inconsistency to be aware of: "Collection Sheet" appears with two different translations in this same file:
- Line 354 (buttons section):
"Sammelblatt"- Line 2805 (text section):
"Inkassoblatt"Both are valid German terms but have slightly different connotations. If this is intentional context-specific variation (buttons vs. descriptive text), it should be documented. If unintentional, consider standardizing to one translation.
All other additions (
Cashiers,Fixed Deposit Account Details,Fund Mapping,Loans Deferred Income,Savings Account Details,Shares Account General,View Cashier) follow consistent naming patterns and appear correctly translated.Since this PR adds translations across 13 languages, please verify:
- That the same keys (
Cashiers,Collection Sheet,Fixed Deposit Account Details, etc.) are added consistently across all 13 language files- That the "Collection Sheet" translation inconsistency (if unintentional) is resolved across all language files
Also applies to: 2805-2805, 3004-3004, 3012-3012, 3066-3066, 3181-3181, 3217-3217, 3283-3283
src/assets/translations/sw-SW.json (10)
2777-2777: Translation key for cashier management functionality added correctly.The addition of
"Cashiers": "Wakusanyaji"in the text section provides the proper Swahili translation for cashier plural form. Consistency verified: existing related keys like"Cashier": "Keshia"(line 1351) and"View Cashiers": "Tazama Washika Fedha"(line 525) use slightly different terminology, which is intentional for context-specific usage.
2805-2805: Collection sheet translation is consistent across sections.The
"Collection Sheet": "Karatasi ya Mkusanyiko"entry matches the identical translation already present in the buttons section (line 354), ensuring consistent terminology throughout the application. Placement in the text section is appropriate for general UI reference.
2854-2854: Savings product creation text added with clear terminology.The translation
"Create Saving Product": "Unda Bidhaa ya Akiba"correctly mirrors existing patterns like "Create Loan Product" (found elsewhere in text section) and uses established terminology for product creation workflows. Terminology aligns with savings-related keys throughout the file.
3004-3004: Fixed deposit account details label added with proper noun phrasing.The
"Fixed Deposit Account Details": "Maelezo ya Akaunti ya Amana Iliyowekwa"translation is semantically correct and maintains consistency with related deposit account terminology used in the file (e.g., "Fixed Deposits Account" context).
3012-3012: Fund mapping translation appropriately added.The
"Fund Mapping": "Ramani ya Fedha"translation is a literal and correct rendering. Consistent with existing mapping terminology found throughout the application (e.g., "Financial Activity Mapping" at line 3296).
3066-3066: Deferred income concept clearly expressed for loan products.The translation
"Loans Deferred Income": "Mapato Yaliyoahirishwa ya Mikopo"correctly conveys the accounting concept of deferred income applied to loans. Terminology is appropriately specialized for financial accounting contexts.
3155-3155: Recurring deposit account details label added with clear product differentiation.The
"Recurring Deposit Account Details": "Maelezo ya Akaunti ya Amana Inayorudiwa"translation properly distinguishes recurring deposits from fixed deposits through Swahili phrasing ("Inayorudiwa" = recurring/repeating). Consistent with product hierarchy used in the file.
3181-3181: Savings account details translation added as general text reference.The
"Savings Account Details": "Maelezo ya Akaunti ya Akiba"entry in the text section complements domain-specific usage already present in heading section (line 1094). Placement is appropriate for general UI label usage.
3217-3217: Shares account general label added for portfolio accounts.The
"Shares Account General": "Akaunti ya Hisa Kwa Ujumla"translation appropriately applies "kwa ujumla" (general/overall) modifier to shares accounts, maintaining consistency with comparable product-specific labels in the text section.
3283-3283: Cashier view action label added consistently.The
"View Cashier": "Tazama Mkusanyaji"uses the singular form "Mkusanyaji" (cashier) paired with "Tazama" (view), consistent with action-verb patterns used throughout the file (e.g., "View Loan", "View Fund" patterns in text section).src/assets/translations/cs-CS.json (9)
2778-2778: Addition of "Cashiers" translation key is properly placed and consistent.The translation "Pokladní" correctly adds the Czech translation for the "Cashiers" label in the text section. The placement and formatting are consistent with adjacent entries.
2806-2806: Addition of "Collection Sheet" translation key is semantically appropriate.The translation "Sběrný list" is a reasonable Czech equivalent for "Collection Sheet" in the financial context. The key is properly positioned in the text section and follows the established format.
3005-3005: Addition of "Fixed Deposit Account Details" translation key is correct.The translation "Podrobnosti účtu s pevným vkladem" accurately captures the meaning of the English label and is consistent with related financial terms already present in the file (e.g., "Fixed Deposit" → "Pevný vklad").
3013-3013: Addition of "Fund Mapping" translation key is semantically correct.The translation "Mapování fondů" appropriately translates the financial/administrative concept into Czech. The term "Mapování" (mapping) is used consistently with other similar technical terms in the file.
3067-3067: Addition of "Loans Deferred Income" translation key is properly contextualized.The translation "Odložené příjmy z půjček" correctly renders this accounting term into Czech, maintaining consistency with existing financial terminology in the file (e.g., "Loans" → "Půjčky", "Deferred income" → "Výnosy příštích období").
3182-3182: Addition of "Savings Account Details" translation key is properly positioned and consistent.The translation "Podrobnosti spořicího účtu" accurately captures the label and follows the pattern established by other account detail entries (e.g., "Fixed Deposit Account Details" → "Podrobnosti účtu s pevným vkladem"). The placement in the text section is appropriate.
3218-3218: Addition of "Shares Account General" translation key is correctly positioned.The translation "Akciový účet obecné" provides a reasonable Czech equivalent for the financial label. The term placement and format are consistent with similar multi-word label entries in the file.
3284-3284: Addition of "View Cashier" translation key is semantically appropriate.The translation "Zobrazit pokladního" is a proper Czech rendering of the UI action label, consistent with other "View [entity]" patterns used throughout the translation file (e.g., "View Fund" → "Zobrazit fond").
1-3699: Overall JSON structure and file integrity are sound.The file maintains proper JSON syntax and nesting throughout. All new entries follow established naming conventions and are placed in semantically appropriate sections. No formatting errors, duplicate keys, or structural issues detected. The translation additions align with the PR objective of adding missing translation keys across 13 language files.
src/assets/translations/pt-PT.json (1)
2778-2778: Verify translation keys are present and review completeness across all language files.The review comment approves 9 new translation additions to the Portuguese translation file (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier). Before approval, manually confirm:
- All 9 keys are present in src/assets/translations/pt-PT.json at the specified line numbers
- JSON structure remains valid (no syntax errors)
- Translations are contextually appropriate for the feature
- All corresponding keys exist in the other 12 language files being updated per WEB-489
src/assets/translations/lv-LV.json (3)
1-3700: JSON structure valid, translations complete for Latvian language additionsAll marked additions contain corresponding Latvian translations with correct character encoding and reasonable semantic translations (e.g., "Cashiers" → "Kasieri", "Fund Mapping" → "Fondu kartēšana", "Savings Account Details" → "Krājkonta informācija"). No syntax errors or empty translation values detected.
354-354: Intentional duplicate key in different sections"Collection Sheet" appears in both
labels.buttons(line 354) andlabels.text(line 2806) with translations "Kolekcijas lapa" and "Iekasēšanas lapa" respectively. While both translate to collection sheet concepts, the slightly different translations suggest this may be deliberate contextual variation. Verify this aligns with the i18n architecture's expectations for section-specific translations.Also applies to: 2806-2806
2778-3350: All 11 new translation keys added for Latvian—verify consistency across 13 language filesThis file adds keys for: Cashiers, Cashier Transactions, Collection Sheet (text section), Fixed/Recurring Deposit Account Details, Fund Mapping, Loans Deferred Income, Savings Account Details, Shares Account General, View Cashier, and Create Saving Product. Per the PR summary, all 13 language files should receive these additions. Confirm parallel updates exist in the other 12 language files (en-US, es-MX, es-CL, de-DE, fr-FR, it-IT, ko-KO, lt-LT, ne-NE, pt-PT, sw-SW, cs-CS).
src/assets/translations/it-IT.json (1)
2778-2778: Review missing translation key additions across labels.text section.All 9 new translation keys have been added to the "labels.text" section with appropriate Italian translations. The entries follow consistent formatting and terminology patterns aligned with existing translations. The JSON structure remains valid with proper syntax.
However, there is a discrepancy between the AI-generated summary and the actual code:
- AI Summary states: "Deleted: Savings Account Details" from Italian public translations
- Code shows (line 3182): "Savings Account Details" → "Dettagli del conto di risparmio" has been added
Please clarify whether "Savings Account Details" should be present in this file or if it was mistakenly included.
To verify the translation keys have been added consistently across all 13 language files, please confirm:
- All 9 new keys (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier) are present in all 13 locale files.
- The Savings Account Details entry was intentionally added/retained (or should be removed if the summary is accurate).
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
src/assets/translations/ko-KO.json (3)
2778-2778: Translation additions are well-integrated and contextually appropriate.The nine new translation keys for cashier, collection sheet, deposit account details, fund mapping, loans deferred income, and shares account features are properly:
- Placed within semantically correct JSON sections (labels.text, labels.heading, labels.menus)
- Formatted consistently with existing entries (key-value pairs with proper punctuation)
- Translated into natural Korean with appropriate terminology for fintech/banking domain
All visible entries follow the existing translation style without syntax errors.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
1-50: Verify that this file is one of 13 language files with identical new keys.Since the PR description states missing translation keys were added to all 13 language files, ensure that:
- The same 9 translation keys (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier) are present in all 12 other language files referenced in the PR summary (en-US, cs-CS, de-DE, es-CL, es-MX, fr-FR, it-IT, lt-LT, lv-LV, ne-NE, pt-PT, sw-SW).
- Keys are placed in the same section hierarchy across all language files for maintainability.
1-3699: Confirm that removed "Savings Account Details" entries were relocated, not lost.The AI summary mentions that "Savings Account Details" entries were "removed and relocated" to reflect reorganized translation structures. The file shows "Savings Account Details" at line 3182, but verify:
- No duplicate "Savings Account Details" keys exist elsewhere in this file
- Any previously-located entries in other sections were intentionally consolidated
- All 13 language files underwent the same consolidation consistently
src/assets/translations/ne-NE.json (3)
1-1: JSON syntax is valid and additions are properly formatted.This translation file adds 9 new Nepali language keys across multiple sections (labels.text, labels.menus, and labels.inputs) for features like cashier management, collection sheets, fund mapping, and various account details. The file structure is sound, with all entries following proper JSON key-value formatting and maintaining nesting integrity.
Also applies to: 3699-3699
2778-2778: Verify translation accuracy with Nepali language stakeholders.The translations provided appear linguistically plausible and follow standard Nepali conventions (e.g., "क्यासियरहरू" for plural "Cashiers"), but without native speaker verification, translation correctness cannot be definitively confirmed. Since this PR adds UI labels that will be directly visible to end users, recommend having Nepali-speaking team members validate these translations before merging.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
2778-2778: Confirm consistency with parallel changes across other language files.The PR description indicates this change is mirrored across 13 language files. Ensure that the added key names match exactly across all language files (e.g., "Cashiers", "Collection Sheet", "Fund Mapping", etc.), and that no keys are missing in this Nepali translation compared to other languages to avoid incomplete i18n coverage.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
src/assets/translations/en-US.json (2)
2788-2788: Verify consistency across all 13 language translation files.The PR objective states that missing translation keys have been added to "all 13 language files," but only the en-US.json file is provided for review. The new translation keys visible here (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier) should be verified to ensure:
- All keys are present in all 13 language files (cs-CS, de-DE, en-US, es-MX, es-CL, fr-FR, it-IT, ko-KO, lt-LT, lv-LV, ne-NE, pt-PT, sw-SW)
- Keys are placed in the same logical sections across all files
- Each language file maintains valid JSON syntax and structure
- No duplicate or conflicting keys exist
Please confirm that corresponding translations have been added to all 12 non-English language files and that the structure is consistent.
Also applies to: 2816-2816, 2865-2865, 3015-3015, 3023-3023, 3161-3161, 3251-3251, 3285-3285, 3324-3324, 3391-3391
1-50: Validate the complete JSON syntax of src/assets/translations/en-US.json.The translation file should be checked for:
- Proper comma placement between all key-value pairs
- Matching braces for all nested objects
- No trailing commas before closing braces
- Proper quote escaping in translation values
This can be validated by running a JSON parser:
python3 -c "import json; json.load(open('src/assets/translations/en-US.json'))"src/assets/translations/es-MX.json (1)
1-3700: Translation file update properly adds missing i18n keys with valid Spanish translations.This change adds 9 missing translation entries to the Spanish (Mexico) locale file across the
labels.textsection. The translations are contextually accurate and follow established naming conventions:
- Lines 2779-2780: "Cashiers" / "Collection Sheet" entries properly placed
- Line 3007: "Fixed Deposit Account Details" uses consistent "Detalles de Cuenta" pattern
- Line 3015: "Fund Mapping" translates to standard financial terminology
- Line 3069: "Loans Deferred Income" correctly renders as "Ingresos Diferidos de Préstamos"
- Lines 3158, 3184, 3220, 3286: Additional account and action labels follow consistent patterns
The JSON structure is valid with proper nesting and comma placement throughout. All translations are grammatically correct Spanish that align with existing terminology in the file.
To confirm completeness, please verify that corresponding translation keys were added to all 13 language files mentioned in the PR description, and that the referenced "removal and relocation" of "Savings Account Details" entries has been applied consistently across all locales.
src/assets/translations/fr-FR.json (3)
1-1: File opens with UTF-8 BOM character—verify intentionality.Line 1 contains a UTF-8 BOM () before the opening brace. While this is valid JSON, confirm this is intentional and present in the original file (not an artifact of file encoding). Most JSON tooling handles this, but it's worth verifying across all 13 translation files for consistency.
2778-2778: New translation keys are properly formatted and placed—French translations appear consistent with existing patterns.All newly added translation keys follow the established structure and naming conventions:
- Keys are properly quoted and placed within appropriate sections (primarily the "text" subsection under "labels")
- Each key has a corresponding French translation value
- Quote escaping and comma placement are correct
- No syntax errors visible in the JSON structure
Example well-formed entries:
- Line 2778~:
"Cashiers": "Caissiers"- Line 3013~:
"Fund Mapping": "Mappage des fonds"- Line 3217~:
"Shares Account General": "Compte d'actions général"Please verify that all French translations are linguistically accurate and contextually appropriate by having a native French speaker or translation specialist review the new entries, particularly domain-specific terms like "Fund Mapping" (Mappage des fonds) and "Collection Sheet" (Feuille de collecte) to ensure they align with the financial terminology used in the Mifos system.
Also applies to: 2806-2806, 2855-2855, 3005-3005, 3013-3013, 3066-3066, 3155-3155, 3181-3181, 3217-3217, 3283-3283
354-354: "Collection Sheet" translation appears in multiple sections—confirm this is intentional multilingual coverage.The term "Collection Sheet" → "Feuille de collecte" now appears in at least three different sections of the file:
- Line 354 (buttons section)
- Line 2580 (menus section)
- Line 2806 (text section)
This is acceptable since UI strings often appear in multiple contexts (buttons, menus, help text), but verify this follows the established pattern for other similarly used terms and that the PR intentionally standardizes this label across contexts.
Confirm with the PR author that this multi-section placement of "Collection Sheet" is intentional and consistent with how other frequently-used UI labels are handled across the translation file.
Also applies to: 2580-2580, 2806-2806
src/assets/translations/es-CL.json (3)
2778-2778: Translation key additions appear well-integrated into file structure.All newly added translation keys (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier) are properly formatted JSON entries with contextually appropriate Spanish translations. Placement within
labels.textandlabels.inputssections is logically consistent with existing entries, and terminology aligns with surrounding translations.Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
2855-2855: Verify naming consistency for "Create Saving Product" key.Line 2855 adds
"Create Saving Product": "Crear Producto de Ahorro". Confirm whether "Saving" (singular) is intentional or should align with plural "Savings" used elsewhere in the file for consistency (e.g., similar patterns like "Create Savings Account").
1-3699: Verification of translation consistency incomplete—missing keys in non-Spanish language files.While the es-CL.json file contains the expected translation keys (e.g., "Cashiers", "Collection Sheet", "Fund Mapping" in the menus section), the other 12 language files have not been provided for review. A proper PR for adding missing translation keys across all 13 language files must:
- Include updates to all language files: cs-CS.json, de-DE.json, en-US.json, es-MX.json, fr-FR.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, and sw-SW.json
- Maintain key-value consistency across all files (all 10 new keys present in every language)
- Verify that any keys removed or relocated are handled consistently across all languages
This change should not be merged without confirming that all 13 language files are properly synchronized.
shubhamkumar9199
force-pushed
the
fix/missing-i18n-keys
branch
from
d04581d to
d886456
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/assets/translations/pt-PT.json (1)
354-354: Inconsistent capitalization in "Collection Sheet" translations.The key "Collection Sheet" has three translations in the file with inconsistent capitalization:
- Line 354 (buttons):
"Folha de Coleta"(capital C)- Line 2580 (menus):
"Folha de coleta"(lowercase c)- Line 2806 (text):
"Folha de coleta"(lowercase c)In Portuguese, common nouns like "coleta" should be lowercase in standard UI labels. For consistency and adherence to Portuguese grammar conventions, standardize all three occurrences to use lowercase:
"Folha de coleta".Apply this diff to standardize the capitalization:
"buttons": { - "Collection Sheet": "Folha de Coleta", + "Collection Sheet": "Folha de coleta",Also applies to: 2580-2580, 2806-2806
🧹 Nitpick comments (1)
src/assets/translations/cs-CS.json (1)
1-3699: Translation file additions appear well-integrated and syntactically sound.The PR successfully adds 9 new translation keys to the Czech (cs-CS) language file. All marked additions are present and properly formatted:
- Lines 2778, 2806, 3005, 3013, 3067, 3156, 3182, 3218, 3284
The translations themselves are semantically accurate and maintain consistency with existing Czech terminology in the file (e.g., "Pokladní" for cashiers, "Mapování fondů" for fund mapping). The JSON structure remains well-formed with proper nesting and closing braces.
Minor observation: The translation "Akciový účet obecné" (line 3218) for "Shares Account General" could be refined—"obecné" is grammatically awkward in this context. Consider: "Akciový účet - Obecné" or "Obecné informace akciového účtu" for better Czech readability.
No critical issues detected. The changes align with the PR objective to add missing UI string translations across language files.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
src/assets/translations/cs-CS.json(9 hunks)src/assets/translations/de-DE.json(9 hunks)src/assets/translations/en-US.json(9 hunks)src/assets/translations/es-CL.json(9 hunks)src/assets/translations/es-MX.json(9 hunks)src/assets/translations/fr-FR.json(10 hunks)src/assets/translations/it-IT.json(9 hunks)src/assets/translations/ko-KO.json(9 hunks)src/assets/translations/lt-LT.json(9 hunks)src/assets/translations/lv-LV.json(9 hunks)src/assets/translations/ne-NE.json(9 hunks)src/assets/translations/pt-PT.json(9 hunks)src/assets/translations/sw-SW.json(9 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- src/assets/translations/es-MX.json
- src/assets/translations/en-US.json
- src/assets/translations/de-DE.json
- src/assets/translations/sw-SW.json
🔇 Additional comments (13)
src/assets/translations/fr-FR.json (3)
1-1: UTF-8 BOM present in file.The file begins with a UTF-8 byte-order mark () at line 1. While this typically doesn't cause issues in modern JSON parsers, it may cause problems in some tooling or environments. Verify this is intentional—most JSON files should omit the BOM.
1-3698: Cross-language consistency cannot be verified from provided context.This PR claims to add the same missing translation keys to all 13 language files, but only the French file (fr-FR.json) is provided for review. To ensure consistency:
- Verify that all 13 language files (cs-CS.json, de-DE.json, en-US.json, es-CL.json, es-MX.json, it-IT.json, ko-KO.json, lt-LT.json, lv-LV.json, ne-NE.json, pt-PT.json, sw-SW.json, and fr-FR.json) have identical key structures (no keys added to only some files).
- Verify that all new keys are present in all 13 locales.
- Consider running a schema or key-list comparison across all translation files to catch any inconsistencies.
2778-2778: New translation keys look complete and well-formed.Spot-checked the key additions mentioned in the PR summary:
- "Cashiers" (line 2778)
- "Collection Sheet" (line 2806)
- "Fixed Deposit Account Details" (line 3005)
- "Fund Mapping" (line 3013)
- "Loans Deferred Income" (line 3066)
- "Recurring Deposit Account Details" (line 3155)
- "Savings Account Details" (line 3181)
- "Shares Account General" (line 3217)
- "View Cashier" (line 3283)
All are present with appropriate French translations that are contextually relevant and grammatically correct.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3066-3066, 3155-3155, 3181-3181, 3217-3217, 3283-3283
src/assets/translations/lv-LV.json (1)
1-3699: ✓ APPROVED: Translation file additions are well-formed and consistent.The Latvian translation file has been updated with new UI string translations as intended. The changes include additions across multiple categories (buttons, labels, headings, text sections, and menus) to support new features like cashier management, collection sheets, account details views, fund mapping, and deferred income tracking.
Observations:
- JSON syntax is valid throughout; all nested structures properly close
- New keys follow established naming conventions and are placed in appropriate sections
- Latvian translations are contextually consistent with existing entries in the file
- The additions align with the PR objectives to support new UI components
Minor notes for awareness:
- The AI summary mentions relocation of "Savings Account Details" entries; confirmed that Line 3182 in
labels.textcontains the relocated entry, and Line 2855 shows "Create Saving Product" (distinct from the "Create Savings Product" pattern used elsewhere)- All new keys appear across the expected sections, and no duplicate keys are present in the file
This is a straightforward localization update and requires no changes before merging.
src/assets/translations/lt-LT.json (1)
3284-3284: ✓ Previous translation concern resolved correctly.The previously flagged issue with "View Cashier" has been properly fixed. The translation now correctly uses:
- The consistent verb "Žiūrėti" (matching other "View" entries like line 525's "View Cashiers": "Žiūrėti Kasininkus")
- The correct accusative case "kasininką" instead of the incorrect locative case
The grammatical and semantic alignment with established patterns in the file is now correct.
src/assets/translations/pt-PT.json (3)
2778-2778: Approve cashier-related translation additions.The translations for "Cashiers" (line 2778) and "View Cashier" (line 3284) are consistent and grammatically correct in Portuguese:
- "Cashiers": "Caixas" ✓
- "View Cashier": "Ver caixa" ✓
These follow proper Portuguese conventions (using lowercase for the noun in the second instance after the imperative verb).
Also applies to: 3284-3284
3005-3005: Approve account detail translations.The new account-specific "Details" translation keys are well-structured and grammatically correct:
- Line 3005: "Fixed Deposit Account Details" → "Detalhes da conta de depósito fixo" ✓
- Line 3156: "Recurring Deposit Account Details" → "Detalhes da conta de depósito recorrente" ✓
- Line 3182: "Savings Account Details" → "Detalhes da conta poupança" ✓
- Line 3218: "Shares Account General" → "Conta de ações geral" ✓
These translations properly follow Portuguese naming conventions for UI labels.
Also applies to: 3156-3156, 3182-3182, 3218-3218
3013-3013: Approve specialized financial term translations.The new specialized translations are appropriate and contextually correct:
- Line 3013: "Fund Mapping" → "Mapeamento de fundos" ✓
- Line 3067: "Loans Deferred Income" → "Receitas diferidas de empréstimos" ✓
These follow standard financial terminology conventions in Portuguese.
Also applies to: 3067-3067
src/assets/translations/es-CL.json (1)
2778-3284: Approve new translation keys for missing UI strings.All added translation keys (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier) are correctly translated into Spanish (Chile) with appropriate context and terminology. The translations align with existing patterns in the file and maintain consistency with product/account naming conventions (where applicable).
src/assets/translations/ko-KO.json (2)
1-3699: JSON structure is valid and all translation additions are properly formatted.The file maintains proper JSON syntax with correct nesting throughout. I've verified the 10 new translation keys mentioned in the PR description are present:
- "Cashiers" (line 2778)
- "Collection Sheet" (line 2806)
- "Fixed Deposit Account Details" (line 3005)
- "Fund Mapping" (line 3013)
- "Loans Deferred Income" (line 3067)
- "Recurring Deposit Account Details" (line 3156)
- "Savings Account Details" (line 3182)
- "Shares Account General" (line 3218)
- "View Cashier" (line 3284)
- Plus one additional: "Savings Product" (line 2855)
Each new translation key has a non-empty Korean translation value, and all are positioned within their appropriate nested sections of the labels hierarchy.
2806-2806: Minor inconsistency note: Verify contextual accuracy of new menu and action labels.Lines 2806 ("Collection Sheet" → "수금 시트") and 3284 ("View Cashier" → "출납원 보기") introduce new UI navigation terms. These are important user-facing strings, so consider verifying with Korean-speaking stakeholders that the translations are natural and contextually appropriate for the menus/buttons they appear in. The translations appear syntactically correct but a domain expert should confirm they match the intended UI context.
Also applies to: 3284-3284
src/assets/translations/it-IT.json (1)
1-3699: Verify JSON syntax validity with a JSON parser before merging.This Italian translation file contains multiple new UI strings with complete Italian translations (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, etc.). The structure appears sound from visual inspection, and terminology is consistent. However, JSON syntax validation could not be performed to confirm there are no edge-case errors such as trailing commas, unclosed braces, or improper escape sequences. Before merging, run a JSON linting tool (such as
python3 -m json.toolorjq) to ensure the file is syntactically valid.src/assets/translations/ne-NE.json (1)
2778-2778: ✓ Well-structured translation additions with proper JSON formatting.The nine new translation keys have been correctly added across the text section with proper Nepali translations using Devanagari script. The JSON structure remains valid with correct nesting, comma placement, and syntax.
Notable observations:
- "Collection Sheet" translations differ by context (line 354: "संग्रह पाना" vs. line 2806: "संकलन पाना"), which is appropriate for different UI contexts
- "Savings Account Details" appears in multiple sections (line 1092 & 3182), confirming the relocations mentioned in the PR description
- All translations follow the established pattern of English keys with Nepali values
To ensure completeness, verify that:
- These keys are actively referenced in the component code and UI templates
- The parallel additions across the 13 locale files (cs-CS, de-DE, en-US, etc.) follow the same key names and structure
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
shubhamkumar9199
force-pushed
the
fix/missing-i18n-keys
branch
from
d886456 to
ee181fc
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (14)
src/app/accounting/closing-entries/view-closure/view-closure.component.html(1 hunks)src/assets/translations/cs-CS.json(9 hunks)src/assets/translations/de-DE.json(9 hunks)src/assets/translations/en-US.json(9 hunks)src/assets/translations/es-CL.json(11 hunks)src/assets/translations/es-MX.json(9 hunks)src/assets/translations/fr-FR.json(10 hunks)src/assets/translations/it-IT.json(9 hunks)src/assets/translations/ko-KO.json(9 hunks)src/assets/translations/lt-LT.json(9 hunks)src/assets/translations/lv-LV.json(9 hunks)src/assets/translations/ne-NE.json(9 hunks)src/assets/translations/pt-PT.json(9 hunks)src/assets/translations/sw-SW.json(9 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/assets/translations/en-US.json
🧰 Additional context used
📓 Path-based instructions (1)
src/app/**
⚙️ CodeRabbit configuration file
src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.
Files:
src/app/accounting/closing-entries/view-closure/view-closure.component.html
🔇 Additional comments (28)
src/assets/translations/ne-NE.json (4)
1-3699: JSON structure is valid and translation additions are well-formatted.The file demonstrates proper JSON structure with correctly formatted translation key-value pairs. The additions (marked with
~) are integrated seamlessly into the existinglabels.textsection with consistent formatting, proper quote escaping, and appropriate comma placement. All nested objects are properly closed, and the overall file structure remains valid.
2778-2778: Missing translation keys have been systematically added across the UI label sections.The PR adds translations for 9 commonly-used UI labels that were previously missing from the Nepali locale:
- Cashier-related: "Cashiers" (क्यासियरहरू) at line 2778, "View Cashier" (क्यासियर हेर्नुहोस्) at line 3284
- Account details views: "Fixed Deposit Account Details", "Recurring Deposit Account Details", "Savings Account Details" (lines 3005, 3156, 3182)
- Financial features: "Collection Sheet" (संकलन पाना) at line 2806, "Fund Mapping" (कोष म्यापिङ) at line 3013
- Loan accounting: "Loans Deferred Income" (स्थगित ऋण आय) at line 3067
- Share management: "Shares Account General" (शेयर खाता सामान्य) at line 3218
All translations follow the established Nepali terminology patterns in the file and maintain consistency with morphological conventions already present in the locale.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
2806-2806: Note: "Collection Sheet" translation location moved within the text section.The translation key "Collection Sheet" → "संकलन पाना" appears in the
textsubsection (line 2806) in this file. The AI summary mentions this was added/relocated. Verify across the other 12 language files that this key placement is consistent and that no duplicate entries exist in thelabels.buttonsor other sections where it may have previously existed.
3182-3182: "Savings Account Details" translation restored to text section with consistent terminology.The "Savings Account Details" (बचत खाता विवरणहरू) translation at line 3182 aligns with similar account-details terminology patterns established for "Fixed Deposit Account Details" and "Recurring Deposit Account Details," indicating a deliberate normalization of the translation hierarchy across account type views.
src/assets/translations/ko-KO.json (1)
2778-2778: Added missing translation keys with appropriate Korean translations.The PR successfully adds nine missing translation keys across the Korean language file, with translations that are consistent with the existing style and terminology. The additions include financial account-related terms (e.g., "Fixed Deposit Account Details", "Collection Sheet", "Cashiers") properly translated to Korean.
The translations follow established naming conventions and terminology patterns already present in the file. JSON structure remains valid.
Verification needed: Please confirm:
- These same keys have been added consistently across all 13 language files (cs-CS, de-DE, en-US, es-CL, es-MX, fr-FR, it-IT, ko-KO, lt-LT, lv-LV, ne-NE, pt-PT, sw-SW)
- Key names match exactly in the reference language file (en-US.json)
- No duplicate key entries exist within the ko-KO.json file after this merge
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
src/assets/translations/sw-SW.json (1)
2777-2777: Translation keys properly formatted and added with consistent Swahili translations.All marked translation additions follow proper JSON structure and maintain consistency with existing translation patterns in the file. The Swahili translations are contextually appropriate and linguistically coherent. Key names align with existing naming conventions across the file (e.g., "View Cashier", "Fund Mapping", "Loans Deferred Income").
Also applies to: 2805-2805, 3004-3004, 3012-3012, 3066-3066, 3155-3155, 3181-3181, 3217-3217, 3283-3283, 2854-2854
src/assets/translations/lv-LV.json (1)
2778-2778: Addition of missing translation keys is well-structured and consistent.The new translation entries for Cashiers, Collection Sheet, Create Saving Product, Account Details variants, Fund Mapping, Loans Deferred Income, and View Cashier are properly integrated within the
labels.textsection of the JSON structure. Translations follow existing naming conventions and appear contextually appropriate. JSON syntax validation passes with proper nesting, commas, and bracket closure maintained throughout.Also applies to: 2806-2806, 2855-2855, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3284-3284
src/assets/translations/cs-CS.json (1)
2778-2778: Translation keys added across multiple sections maintain proper JSON structure and naming conventions.The added translation entries (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier, etc.) are correctly positioned within their respective nested sections (text, menus, inputs), follow the existing key naming pattern, and maintain valid JSON syntax with proper quoting and comma placement. The file's root structure remains intact with all objects and arrays properly closed.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
src/app/accounting/closing-entries/view-closure/view-closure.component.html (1)
42-42: Translation key normalized from title case to lowercase for consistency.The template update changes the translation key reference from
'labels.inputs.Updated On'to'labels.inputs.Updated on'(lowercase 'o' in 'on'), which aligns with the standardized key naming in the translation files. This change is consistent with the PR's goal of adding and normalizing missing translation keys. The translate pipe is used correctly with Angular's proper syntax.To confirm this key normalization is applied consistently across all 13 language files in the PR, verify that each language file contains the 'labels.inputs.Updated on' key (with lowercase 'on') rather than the previous 'Updated On' variant.
src/assets/translations/fr-FR.json (1)
1-3698: JSON structure and translation keys are properly formatted.This translation file update adds missing UI keys in French across the "labels.text" namespace (e.g., "Cashiers", "Collection Sheet", "Fixed Deposit Account Details", "Fund Mapping", "Loans Deferred Income", "Recurring Deposit Account Details", "Savings Account Details", "Shares Account General", "View Cashier"). The JSON structure is valid with consistent indentation and proper key nesting. All translations follow the existing terminology conventions used throughout the file.
Note: The semantic accuracy of French translations and completeness of missing keys across all 13 locale files mentioned in the PR should be verified by someone with native French fluency and domain knowledge of the Mifos X microfinance platform. Consider spot-checking a few key translations (e.g., "Fixed Deposit Account Details" = "Détails du compte de dépôt à terme") for contextual appropriateness before merging.
src/assets/translations/de-DE.json (1)
2778-2778: German translations are accurate and contextually appropriate; JSON structure is valid.The new translation keys added for German are of high quality:
- Financial terminology is standard and consistent (Kassierer, Festgeldkonto, Sparkonto, Fondszuordnung)
- Terminology aligns with existing translations in the file (e.g., "Konto" suffix pattern for accounts)
- Proper formatting and grammar for German noun phrases
JSON structure remains valid with correct nesting and syntax.
Since this file is one of 13 language files being updated per the PR summary, please verify cross-file consistency by confirming:
- All 13 language files contain these same translation keys (Cashiers, Collection Sheet, Fixed Deposit Account Details, Fund Mapping, Loans Deferred Income, Recurring Deposit Account Details, Savings Account Details, Shares Account General, View Cashier)
- No keys were accidentally removed or duplicated during the "rehoming" process mentioned in the summary
- All files maintain the same hierarchical structure for these new keys
Also applies to: 2805-2805, 3004-3004, 3012-3012, 3066-3066, 3155-3155, 3181-3181, 3217-3217, 3283-3283
src/assets/translations/es-CL.json (2)
2854-2856: ✓ Past translation inconsistency resolved.The previous review flagged inconsistent translations for "Saving Product" vs. "Savings Account." The current version correctly maintains consistency across all three related keys by using "Producto de Ahorro" (Product) rather than "Cuenta de Ahorros" (Account):
- Line 2855: "Create Saving Product" → "Crear Producto de Ahorro"
- Line 2962: "Edit Saving Product" → "Editar Producto de Ahorro"
- Line 3317: "View Saving Product" → "Ver Producto de Ahorro"
Also applies to: 2962-2962, 3317-3317
2777-2777: ✓ Missing translation keys added with appropriate Spanish localization.The PR adds 12 previously missing translation keys to the es-CL.json file. All new entries demonstrate proper terminology choices and consistency with existing translations:
- Cashier-related: "Cashiers" and "View Cashier" use consistent "Cajero/Cajeros" terminology
- Account details: "Fixed Deposit Account Details," "Recurring Deposit Account Details," and "Savings Account Details" use appropriate "Detalles de Cuenta..." formatting
- UI controls: "Collection Sheet" ("Hoja de recaudación"), "Fund Mapping" ("Mapeo de Fondos"), "Shares Account General" ("Cuenta de Acciones General") all follow established terminology patterns
- Financial concepts: "Loans Deferred Income" ("Ingresos Diferidos de Préstamos") correctly translates deferred income concepts
No translation gaps, typos, or inconsistencies detected among the new additions.
Also applies to: 2806-2806, 3005-3005, 3013-3013, 3067-3067, 3156-3156, 3182-3182, 3218-3218, 3284-3284
src/assets/translations/es-MX.json (4)
2779-2810: Verify translation consistency for "Collection Sheet" terminology.Two variants exist in this file:
- Line 354: "Collection Sheet" → "Hoja de recuperación"
- Line 2808: "Collection Sheet" → "Hoja de recaudación"
The new entry at line 2808 uses "recaudación" (fund collection) instead of "recuperación" (recovery). Confirm this terminology choice is intentional and aligns with the financial context and other 12 language files.
3013-3017: Standardize capitalization in "Fund Mapping" translation.Two entries exist with inconsistent capitalization:
- Line 950: "Mapeo de fondos," (lowercase)
- Line 3015: "Mapeo de Fondos," (capitalized)
Standardize to follow Spanish grammar conventions (typically lowercase: "Mapeo de fondos"). Verify this is consistent across all 13 language files.
2854-2860: Flag potential key duplication: "Create Saving Product" vs "Create Savings Product".Two keys exist in this file:
- Line 900: "Create Savings Product" (plural)
- Line 2857: "Create Saving Product" (singular)
Both map to the same translation: "Crear Producto de Ahorro". Confirm if both keys are intentional (perhaps for different UI contexts) or if this represents unintended duplication. Check consistency across all 13 language files.
1-3701: JSON structure and formatting are valid; file is syntax-correct.The translation file is properly formatted as valid JSON with:
- Correct object/array syntax
- Proper key-value pair formatting
- Consistent comma placement
- Matching braces and brackets
No syntax errors detected that would prevent deployment.
src/assets/translations/lt-LT.json (10)
2778-2778: ✓ Proper Lithuanian nominative plural form for "Cashiers".The translation "Kasininkai" correctly uses the nominative plural case for this new addition to the text section.
2806-2806: Verify translation consistency for "Collection Sheet".The new text-section entry uses "Surinkimo lapas," but existing entries in the same file use "Kolekcijos lapas" (buttons at line 354, menus at line 2580). Both are grammatically valid Lithuanian, but using different base forms (Surinkimas vs. Kolekcija, both meaning "collection") creates terminology inconsistency. Confirm whether this variation is intentional for different UI contexts or should be standardized.
2855-2855: ✓ Correct accusative case and established verb pattern."Sukurti taupymo produktą" properly uses the accusative case (produktą) and follows the established "Create" verb pattern used throughout the file.
3005-3005: ✓ Consistent with existing Account Details translation pattern."Terminuoto indėlio sąskaitos informacija" follows the standard pattern for account detail entries (genitive construction + "informacija"). Grammar is correct.
3013-3013: ✓ Proper genitive plural form for "Fund Mapping"."Fondų susiejimas" correctly uses the genitive plural (fondų) paired with nominative nominalization (susiejimas). Grammatically sound.
3067-3067: ✓ Correct feminine plural and genitive forms for "Loans Deferred Income"."Atidėtos paskolų pajamos" properly applies feminine plural agreement (atidėtos matches pajamos, both feminine) and genitive case for paskolų. Grammatically accurate.
3156-3156: ✓ Consistent pattern with Fixed Deposit Account Details."Periodinio indėlio sąskaitos informacija" mirrors the established account details pattern, with proper genitive constructions throughout.
3182-3182: ✓ Grammatically correct genitive forms for Savings Account Details."Taupomosios sąskaitos informacija" uses consistent genitive case structure and agrees with established translation patterns for similar account-type entries.
3218-3218: ✓ Correct nominative agreement for "Shares Account General"."Akcijų sąskaita bendra" properly uses genitive (akcijų) with nominative singular account term (sąskaita) and nominative feminine adjective (bendra). Consistent with similar entries.
3284-3284: ✓ Previously flagged grammar issue now resolved."Žiūrėti kasininką" correctly applies:
- Consistent verb choice (Žiūrėti, matching other "View" actions throughout the file)
- Proper accusative case (kasininką vs. the previously incorrect locative kasininke)
This addresses the issue flagged in past review (commit d886456 reference).
src/assets/translations/it-IT.json (1)
1-3699: JSON structure is properly formatted; cross-locale synchronization requires verification.The Italian translation file (
src/assets/translations/it-IT.json) displays correct JSON structure throughout all 3699 lines: proper bracket nesting, consistent key-value formatting, and appropriate comma placement. New translation entries integrate seamlessly with existing hierarchical patterns (errors.*,labels.text.*,labels.inputs.*,labels.buttons.*,labels.heading.*,tooltips.*,countries.*).Comprehensive verification requires checking that all 13 language files maintain synchronized translation keys to prevent missing locale strings at runtime. Confirm that:
- All corresponding locale files (
en-US.json,es-MX.json,fr-FR.json, etc.) contain identical keys- No keys were added to it-IT.json without parallel additions to other locales
- File remains valid JSON (validate with
jq emptybefore merge)
…all language files orrect accusative case kasininką instead of locative kasininke Fixed! The translations in es-CL.json have been corrected Fixed the incomplete translation
shubhamkumar9199
force-pushed
the
fix/missing-i18n-keys
branch
from
ee181fc to
240bdbe
Compare
alberto-art3ch
left a comment
alberto-art3ch
left a comment
There was a problem hiding this comment.
In general looks fine, but squash your commits
3 participants
This pr Added all missing translation keys to all 13 language files:
(e.g., labels.text.Collection Sheet, labels.inputs.Updated )
#{Issue Number}
WEB-489
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.