Skip to content

WEB-464 Lock in Period Field Allows Zero and Negative Values in Share Product Creation Form #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JaySoni1 wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −2
Open

WEB-464 Lock in Period Field Allows Zero and Negative Values in Share Product Creation Form #2882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...re-product-stepper/share-product-settings-step/share-product-settings-step.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,13 @@ <h4 class="mat-h4 flex-98">

<mat-form-field class="flex-48">
<mat-label>{{ 'labels.inputs.Frequency' | translate }}</mat-label>
<input type="number" matInput formControlName="lockinPeriodFrequency" />
<input type="number" matInput formControlName="lockinPeriodFrequency" min="1" step="1" required />
<mat-error *ngIf="shareProductSettingsForm.get('lockinPeriodFrequency').hasError('required')">
Frequency is <strong>required</strong>
</mat-error>
<mat-error *ngIf="shareProductSettingsForm.get('lockinPeriodFrequency').hasError('min')">
Frequency must be greater than zero
</mat-error>
</mat-form-field>

<mat-form-field class="flex-48">
Expand Down
8 changes: 7 additions & 1 deletion ...hare-product-stepper/share-product-settings-step/share-product-settings-step.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,13 @@ export class ShareProductSettingsStepComponent implements OnInit {
maximumShares: [''],
minimumActivePeriodForDividends: [''],
minimumactiveperiodFrequencyType: [''],
lockinPeriodFrequency: [''],
lockinPeriodFrequency: [
'',
[
Validators.required,
Validators.min(1)
]
],
lockinPeriodFrequencyType: [''],
allowDividendCalculationForInactiveClients: [false]
});
Expand Down
Loading