Skip to content

fix(ui): add missing aria-labels and alt attributes for better accessibility #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NotxNoodles wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix(ui): add missing aria-labels and alt attributes for better accessibility #3318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cebf558
fix(ui): add missing aria-labels and alt attributes for better access…
NotxNoodles Mar 5, 2026
1f22024
fix(i18n): add missing translation keys to all language files
NotxNoodles Mar 20, 2026
6edac30
fix(i18n): replace English fallbacks with proper translations
NotxNoodles Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/groups/groups-view/groups-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<mat-card-title-group class="header-title-group">
<div class="profile-image-container">
<div>
<img mat-card-md-image class="profile-image" src="assets/images/group_placeholder.png" />
<img mat-card-md-image class="profile-image" src="assets/images/group_placeholder.png" alt="" role="presentation" />
</div>
</div>

Expand Down
2 changes: 1 addition & 1 deletion src/app/savings/savings-account-view/transactions-tab/transactions-tab.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<ng-container matColumnDef="actions">
<th mat-header-cell class="center" *matHeaderCellDef>{{ 'labels.inputs.Actions' | translate }}</th>
<td mat-cell class="center" *matCellDef="let transaction">
<button mat-icon-button [matMenuTriggerFor]="transactionMenu" aria-label="" class="action-button">
<button mat-icon-button [matMenuTriggerFor]="transactionMenu" [attr.aria-label]="'labels.inputs.Transaction Actions' | translate" class="action-button">
<mat-icon>more_vert</mat-icon>
</button>
<mat-menu #transactionMenu="matMenu">
Expand Down
5 changes: 3 additions & 2 deletions src/app/shared/theme-toggle/theme-toggle.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<!--
<!--
Copyright since 2025 Mifos Initiative

This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/.
-->
<button mat-icon-button (click)="toggleTheme()" class="m-l-5 m-r-5">
<button mat-icon-button (click)="toggleTheme()" class="m-l-5 m-r-5"
[attr.aria-label]="(darkModeOn ? 'labels.text.Switch to Light Mode' : 'labels.text.Switch to Dark Mode') | translate">
<mifosx-m3-icon [name]="darkModeOn ? 'wb_sunny' : 'nights_stay'"></mifosx-m3-icon>
</button>
3 changes: 3 additions & 0 deletions src/assets/translations/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,6 +2639,7 @@
"Town / Village": "Town / Village",
"Trail ID": "Trail ID",
"Transaction": "Transaction",
"Transaction Actions": "Transaction Actions",
Copy link
Collaborator

@alberto-art3ch alberto-art3ch Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the translation in the other languages

"Transaction Amount": "Transaction Amount",
"Transaction Date": "Transaction Date",
"Transaction Date From": "Transaction Date From",
Expand Down Expand Up @@ -3683,6 +3684,8 @@
"Start filling the details": "Click to start filling the details. * mark fields are necessary.",
"Step": "Step",
"Supports Loan charges, Savings & deposits": "This option allows you to create new charges. It supports Loan charges, Savings and deposits charges and Client charges.",
"Switch to Dark Mode": "Switch to Dark Mode",
"Switch to Light Mode": "Switch to Light Mode",
"System": "System",
"System Information": "System Information",
"Software Licensing": "Software Licensing",
Expand Down