-
Notifications
You must be signed in to change notification settings - Fork 17
Add some commonly-used communication protocols #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
instances/latest/terminologies/communicationProtocol/https.jsonld
Outdated
Show resolved
Hide resolved
| "@context": { | ||
| "@vocab": "https://openminds.om-i.org/props/" | ||
| }, | ||
| "@id": "https://openminds.om-i.org/instances/communicationProtocol/tcp-ip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure for this one: if it would be "tcp-ip" like right now or "tcp_ip" instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should indeed be tcp_ip
Co-authored-by: Raphael-Gazzotti <[email protected]>
lzehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apdavison please double check my updates and let me know if all is good.
Notes:
(1) For abbreviations and names we keep the capitalization in the at_id and in the filename.
(2) "/" is replaced with "_" in at_id and filename.
| "@context": { | ||
| "@vocab": "https://openminds.om-i.org/props/" | ||
| }, | ||
| "@id": "https://openminds.om-i.org/instances/communicationProtocol/tcp-ip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should indeed be tcp_ip
|
@elenimath please have a look |
Implements some terms suggested in #317
Requires openMetadataInitiative/openMINDS_controlledTerms#504 to be merged first.