Skip to content

Conversation

@apdavison
Copy link
Member

@apdavison apdavison commented Sep 20, 2025

Implements some terms suggested in #317

Requires openMetadataInitiative/openMINDS_controlledTerms#504 to be merged first.

"@context": {
"@vocab": "https://openminds.om-i.org/props/"
},
"@id": "https://openminds.om-i.org/instances/communicationProtocol/tcp-ip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure for this one: if it would be "tcp-ip" like right now or "tcp_ip" instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should indeed be tcp_ip

Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apdavison please double check my updates and let me know if all is good.

Notes:
(1) For abbreviations and names we keep the capitalization in the at_id and in the filename.
(2) "/" is replaced with "_" in at_id and filename.

"@context": {
"@vocab": "https://openminds.om-i.org/props/"
},
"@id": "https://openminds.om-i.org/instances/communicationProtocol/tcp-ip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should indeed be tcp_ip

@lzehl
Copy link
Member

lzehl commented Oct 3, 2025

@elenimath please have a look

@Raphael-Gazzotti Raphael-Gazzotti merged commit 54d66ef into main Oct 10, 2025
4 checks passed
@Raphael-Gazzotti Raphael-Gazzotti deleted the add-communication-protocol-library branch October 10, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants