add sovereignStates [4/7] #379
Conversation
Raphael-Gazzotti
added
request
There was a problem hiding this comment.
"Rige" is correct spelling, should be added as an exception to the code spell
signybenediktsdottir
left a comment
signybenediktsdottir
left a comment
There was a problem hiding this comment.
Could be merged but see comments on specific files first.
There was a problem hiding this comment.
NED is included in wikidata, abbreviation for Netherlands (https://en.wiktionary.org/wiki/NED). Should be added as an exception.
There was a problem hiding this comment.
Official name "Lebanon" also included as a synonym
There was a problem hiding this comment.
Country code "ISO 3166-1:LB" included in wikidata. Should this also be included on the instance?
There was a problem hiding this comment.
"Lubnan" could also be added as this is listed under native label on wikidata
There was a problem hiding this comment.
Official name "Lesotho" is included also as a synonym
There was a problem hiding this comment.
"Charu cha Malaŵi" is listed as native label on wikidata, could be added as a synonym
There was a problem hiding this comment.
Official name "Mali" also included as a synonym
There was a problem hiding this comment.
"bu" correct according to native label in wikidata for Wolof. Should be added as an exception to the code spell
There was a problem hiding this comment.
Official name "Moldova" is also listed as a synonym
There was a problem hiding this comment.
Offical name "Monaco" also listed as a synonym
|
@Raphael-Gazzotti for some countries the official name of the country is also included as a synonym. Could this be because the values from "native label" (wikidata) are included as a synonym? If that is the case, should I remove the official name listed under synonyms? |
|
@signybenediktsdottir Yes, we can remove them. They were included because I extracted them from other properties, but I should have removed them since they were already present for the property name. Sorry. |
|
Just removed the duplicates between the names and synonyms. The rest was already included, i.e., LB, Charu cha Malaŵi... |
changes to rerun checks (no changes were made)
signybenediktsdottir
merged commit d97df44
into
openMetadataInitiative:main
2 participants
No description provided.