Fix Variant issue with certain Cuda versions #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
franzpoeschel
force-pushed
the
fix-variant-in-public-headers
branch
from
fc091b1 to
308b91a
Compare
ax3l
reviewed
Dec 2, 2025
ax3l
approved these changes
Dec 2, 2025
Member
ax3l
left a comment
ax3l
left a comment
There was a problem hiding this comment.
LGTM, please just rename MovableUniquePtr to Copyable... and then it can go.
This should fix the Cuda issues. Will not yet work with ADIOS2
franzpoeschel
force-pushed
the
fix-variant-in-public-headers
branch
from
308b91a to
05a2c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1720
Enabled mostly by #1774, the refactorings therein make it possible to workaround the issues that some Cuda versions have with std::variant in C++20.
Only need to hide one further std::variant from public headers.
TODO: