Skip to content

Fix BaseRecord::erase / deletion #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ax3l merged 2 commits into from
Jan 17, 2026
Merged

Fix BaseRecord::erase / deletion #1841

ax3l merged 2 commits into from
Jan 17, 2026
+55 −42

Conversation

@franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Jan 16, 2026

Implementation was weirdly complicated and led to errors.

@franzpoeschel franzpoeschel added this to the 0.17.0 milestone Jan 16, 2026
@franzpoeschel franzpoeschel requested a review from ax3l January 16, 2026 15:57
@franzpoeschel franzpoeschel enabled auto-merge (squash) January 16, 2026 15:59
ax3l
ax3l approved these changes Jan 17, 2026
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ax3l ax3l self-assigned this Jan 17, 2026
@ax3l ax3l added the bug label Jan 17, 2026
@ax3l ax3l disabled auto-merge January 17, 2026 17:57
@ax3l ax3l merged commit 1cfc68c into openPMD:dev Jan 17, 2026
30 of 31 checks passed
@ax3l ax3l changed the title Fix deletion Fix BaseRecord::erase / deletion Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels

bug

Projects

None yet

Milestone

0.17.0

Development

Successfully merging this pull request may close these issues.

2 participants

@franzpoeschel @ax3l