Open
Conversation
Moved to finalize(), degraded to warning
prep for reading
but still warnings
franzpoeschel
force-pushed
the
synchronous-flush
branch
from
53bdf60 to
9c02a26
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+281
to
+284
| std::vector<double> res(udims.size() * 7); | ||
| // for (size_t i = 0; i < udims.size(); ++i) | ||
| // { | ||
| // res[7 * i] = 1; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| auto init_directly = [this, &comm..., &filepath]( | ||
| std::unique_ptr<ParsedInput> parsed_input, | ||
| json::TracingJSON tracing_json) { | ||
| json::TracingJSON tracing_json, |
Check notice
Code scanning / CodeQL
Large object passed by value Note
| // Template implementations from header | ||
| template <typename T, typename RecordType> | ||
| PostProcessConvertedAttributeImpl<T, RecordType>:: | ||
| PostProcessConvertedAttributeImpl(RecordType record_in, handler_t reader_in) |
Check notice
Code scanning / CodeQL
Large object passed by value Note
Comment on lines
+698
to
+701
| // TODO: unitSI | ||
| // REQUIRE(r["x"].numAttributes() == 0); | ||
| // REQUIRE(r["y"].numAttributes() == 0); | ||
| // REQUIRE(r["z"].numAttributes() == 0); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
| else | ||
| { | ||
| auto read_again = E_x_read.loadChunk<int>({0, 0}, {mpi_size, 4}); | ||
| // REQUIRE_THROWS(read.flush()); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
franzpoeschel
force-pushed
the
synchronous-flush
branch
from
9c02a26 to
3b5c07f
Compare
franzpoeschel
force-pushed
the
synchronous-flush
branch
from
3b5c07f to
c725c7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flush immediately upon
storeChunk()/loadChunk(), no flushing neededTODO: