Open
Conversation
Arbaaz123676
force-pushed
the
fix-scm-token-disable
branch
from
67119c4 to
8b0e6c2
Compare
hellcp-work
reviewed
Mar 13, 2026
| # "Failed to report back to GitHub: Request is forbidden." | ||
|
|
||
| token.update(enabled: false) if message.include?('Unauthorized request') || /Request (is )?forbidden/.match?(message) | ||
| if fail? && ( |
Contributor
There was a problem hiding this comment.
We set status: fail 12 lines above, so fail? here will always be true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The circuit breaker logic disabled SCM tokens purely based on message content matching. This could lead to false positives where tokens were disabled even though the workflow delivery succeeded.
This patch ensures that the token is only disabled when the workflow status is
failand the error message indicates an authorization failure (Unauthorized or Forbidden).Additionally, safe navigation is used when updating the token to avoid errors when the token is nil.
Note: I couldn’t run locally due to Gemfile dependency issues.
Fixes #19183