Skip to content

Another take to use arch when selecting repo for build target#1097

Open
abitrolly wants to merge 2 commits intoopenSUSE:masterfrom
abitrolly:select-arch
Open

Another take to use arch when selecting repo for build target#1097
abitrolly wants to merge 2 commits intoopenSUSE:masterfrom
abitrolly:select-arch

Conversation

@abitrolly
Copy link
Copy Markdown
Contributor

This is another attempt to solve problem that osc build selects OpenSuse_Tumbleweed even if this selection doesn't fit the required architecture.

#241 (comment)

  • trace the role of no_repo
  • trace the role of repo_names
  • check offline logic is not broken (check that offline still
    needed a non-empty repo list before this change)

* [ ] trace the role of `no_repo`
* [ ] trace the role of `repo_names`
* [ ] check offline logic is not broken (check that offline still
      needed a non-empty repo list before this change)
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2022

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.95%. Comparing base (43337af) to head (e1dcec7).
⚠️ Report is 1885 commits behind head on master.

Files with missing lines Patch % Lines
osc/commandline.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   22.95%   22.95%   -0.01%     
==========================================
  Files          27       27              
  Lines       16368    16373       +5     
==========================================
  Hits         3758     3758              
- Misses      12610    12615       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hramrach
Copy link
Copy Markdown
Contributor

hramrach commented Aug 3, 2022

r.arch == arg_arch looks fishy, shouldn't there be a list somewhere?

@abitrolly
Copy link
Copy Markdown
Contributor Author

It is a string comparison of arch that osc repos gives.

@hramrach
Copy link
Copy Markdown
Contributor

hramrach commented Aug 3, 2022

So it returns the same repo multiple times with different arch

@hramrach
Copy link
Copy Markdown
Contributor

hramrach commented Aug 3, 2022

Does not work for me:

localhost:~/home:michals/vertest # osc -d build
hostarch: armv7l
arg_arch: armv7l
arg_repository: None
arg_descr: None
no configured repos for arch armv7l

@abitrolly
Copy link
Copy Markdown
Contributor Author

That was a mistake indeed. Fixed that part.

@hramrach
Copy link
Copy Markdown
Contributor

hramrach commented Aug 3, 2022

Looks like this works, thanks

osc -d build
hostarch: armv7l
arg_arch: armv7l
arg_repository: None
arg_descr: None
Building vertest.spec for openSUSE_Leap_15.2_Ports/armv7l

@dmach
Copy link
Copy Markdown
Contributor

dmach commented Mar 9, 2023

This pull request has been in a draft state for quite some time.
Could you either finish it, close it or add a comment that you're still planning to work on it?

@abitrolly abitrolly marked this pull request as ready for review March 9, 2023 18:38
@abitrolly
Copy link
Copy Markdown
Contributor Author

@dmach it looks like this PR improves error messages, but I don't remember what I was trying to do and if it reaches that point. Feel free to close it if it has no value.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 200 days with no activity.

@github-actions github-actions Bot added stale and removed stale labels Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants