Draft
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| newinstance=False, | ||
| disable_build=False, | ||
| ): | ||
| ) -> Tuple[False, Optional[str], Optional[str], Optional[str], Optional[str]]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| maintenance=False, | ||
| newinstance=False, | ||
| disable_build=False, | ||
| ) -> Union[Tuple[True, str, str, None, None], Tuple[False, Optional[str], Optional[str], Optional[str], Optional[str]]]: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
Contributor
|
I've rebased the pull request. If it looks fine to you, let's merge it. |
Member
Author
It now broke all rpmbuilds because there's no typing_extensions available. I could change it to import from typing conditionally and add typing_extensions for old pythons |
dcermak
force-pushed
the
type-hints
branch
2 times, most recently
from
e8622aa to
227f63f
Compare
| from io import StringIO | ||
| from pathlib import Path | ||
| from typing import Optional, Dict, Union, List, Iterable | ||
| from typing import TYPE_CHECKING, Any, Optional, Dict, Union, List, Iterable, Tuple, overload |
Check notice
Code scanning / CodeQL
Unused import Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.