Use typeguard during tests and in osc-wrapper.py#1424
Use typeguard during tests and in osc-wrapper.py#1424dmach wants to merge 2 commits intoopenSUSE:masterfrom
Conversation
|
Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-07 08:51:16 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 31.47% 31.26% -0.21%
==========================================
Files 103 49 -54
Lines 19070 17820 -1250
==========================================
- Hits 6002 5572 -430
+ Misses 13068 12248 -820 ☔ View full report in Codecov by Sentry. |
53d81f0 to
34731ee
Compare
6cbad76 to
21e78e0
Compare
| %endif | ||
|
|
||
| # use typeguard during build on distros where typeguard is available | ||
| %if (0%{?suse_version} > 1500 || 0%{?fedora} >= 37) |
There was a problem hiding this comment.
We don't have to care about Fedora 36 and older
| %if (0%{?suse_version} > 1500 || 0%{?fedora} >= 37) | |
| %if (0%{?suse_version} > 1500 || 0%{?fedora}) |
3bb44b0 to
41918fd
Compare
It is also possible to use typeguard in osc-wrapper.py by setting OSC_TYPEGUARD=1.
No description provided.