Draft
Conversation
fb064c1 to
4365ec8
Compare
- Introduced openSUSE/Leap product and relative submodules. - Updated gitea.sh to create test-GitPkgB package and push to remote. - Added feature tests for git-obs staging group command. - Enhanced Behave GitObs class to allow dynamic login name configuration. - Updated StagingGroupCommand to handle fork repository arguments and validations. - Improved error handling for missing labels in pull requests.
…and configurations
…mmand - staging_group: Handle missing 'fork' remote by adding it instead of trying to update a non-existent remote. Use try/except to gracefully fall back to 'git remote add' when 'set-url' fails. - behave tests: Set git identity env vars (GIT_AUTHOR_NAME/EMAIL, GIT_COMMITTER_NAME/EMAIL) when switching logins so commits are attributed to the correct user. - behave tests: Clear GIT_SSH_COMMAND when switching logins to allow git-obs to use its own SSH key management (core.sshCommand) without being overridden by keys from previous test users. - Add test scenario for fork creation in a specified organization, verifying that --fork-owner works with org-owned forks. Fixes authentication issues where git operations were incorrectly attributed to Admin when running as Alice due to persisting GIT_SSH_COMMAND environment variable. Fixes: #2057
4365ec8 to
e8d9890
Compare
…onality - Create test-GitPkgC package with initial commits and submodule integration. - Update staging group command to handle exceptions when updating pull requests. - Improve SSH key management for git commands in the context of user logins. - Refactor pull request body updates to ensure case-insensitive owner and repo references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends
git-obs staging groupwith two main features and fixes a test authentication bug.--fork-owner / --fork-repo enhancements
staging group can now create new staging PRs using a fork owned by an organization instead of only the current user. Previously, specifying --fork-owner would fail when pushing because the fork remote was never added to the cloned target repo (only user-owned forks are auto-detected by Repo.clone()).
When the target PR's head repository is a fork and we have push access, try git remote set-url fork and fall back to git remote add fork if the remote doesn't exist yet.
Adds a new ssh_strict_host_key_checking field to the login config, so SSH host key verification can be disabled per-login without using command-line flags (required for behave tests).
Behave test fixes
New behave tests
git-staging-group.feature: full integration test scenarios for the staging group command, including setup of staging PRs, label assignment, and a new scenario for --fork-owner fork creation.
Related to #2057