Testing: optimizations for labsconf 2021 talk #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and remove_kmp_modules
The first call is supposed to check whether the kernel at hand is in an inconsistent state before adding the KMP. But this is a very rare situation; has_unresolved_symbols() is a slow operation (calling depmod) and should thus not be called without good reason. If adding the kmp failed and OPT_DEBUG=1, we carry out this operation to provide a clue to users.
Fall back to full depmod if this fails
This test is bogus because remove_kmp() is called after the actual package removal. The symlinks may still be present, but either point to a different KMP, or be stale.
Rather than reading "_kernel_" from stdin, use a function argument.
With initrd in posttrans and incremental depmod, the logic for depmod and initrd rebuilding will become different.
Like for KMPs, the information whether modules are present in the initrd is also valuable for deciding if the intird must be rebuilt for kernel subpackages. For the time being, we always set the _kernel_ flag, forcing the initrd to be rebuilt for these packages, too.
With this patch, if the $INITRD_IN_POSTTRANS environment variable is set in weak-modules2's environment, it will postpone the rebuilding of the initramfs to the %posttrans stage if possible. Also, for kernel subpackages like -extra or -optional, the initrd rebuild will only be triggered if it's necessary (i.e. if the current initrd contains at least one of the modules in the package).
Contributor
Author
|
Closing in favor of #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.