Open
Conversation
7f1e5ce to
4ca5bdf
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ca5bdfe6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
50f11ae to
f4eec12
Compare
f4eec12 to
beba899
Compare
beba899 to
e61e0cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why We Did This
search_tool_bm25) so the model narrows tool scope before making MCP calls, which helps relevance and lowers prompt/tool clutter.What It Changed
search_toolincore/src/features.rs:90andcore/src/features.rs:430.core/config.schema.json:214andcore/config.schema.json:1235.bm25) inCargo.toml:129andcore/Cargo.toml:23.search_tool_bm25incore/src/tools/handlers/search_tool_bm25.rs:18.core/src/tools/handlers/mod.rs:11andcore/src/tools/spec.rs:780andcore/src/tools/spec.rs:1344.ToolsConfigto carrysearch_toolenablement incore/src/tools/spec.rs:32andcore/src/tools/spec.rs:56.core/src/codex.rs:483andcore/src/codex.rs:1976, usingcore/templates/search_tool/developer_instructions.md:1.core/src/state/session.rs:27andcore/src/state/session.rs:131.core/src/codex.rs:3800andcore/src/codex.rs:3843.core/tests/suite/search_tool.rs:72,core/tests/suite/search_tool.rs:109,core/tests/suite/search_tool.rs:147, andcore/tests/suite/search_tool.rs:218.core/tests/suite/tools.rs:281.Net Behavioral Effect
search_tooloff: existing MCP behavior (tools exposed normally).search_toolon: MCP tools start hidden, model must callsearch_tool_bm25, and only returnedselected_toolsare available for the next model call.