fix: ensure resume args precede image args#10709
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
I have read and agree to the Contributor License Agreement (CLA). |
|
@cryptonerdcn, we've updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement. That said, this is a nicely-scoped fix that's easy to review & validate, so consider yourself invited. :) In the future, please discuss a fix in the issue tracker and wait for an invitation before opening a PR. |
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Fixes argument ordering when
resumeThread()is used withlocal_image. The SDK previously emitted CLI args with--imagebeforeresume <threadId>, which caused the Codex CLI to treatresume/UUID as image paths and start a new session. This PR movesresume <threadId>before any--imageflags and adds a regression test.Bug Report / Links
Repro (pre-fix)
--image <path> resume <id>Fix
Move
resume <threadId>before--imageinCodexExec.runand add a regression test to assert ordering.Tests
cd sdk/typescript && npm testcodex-rs/target/debug/codexmissing (ENOENT)Notes
codex-rsbuilt and report results.