Skip to content

fix: ensure resume args precede image args#10709

Merged
etraut-openai merged 1 commit intoopenai:mainfrom
cryptonerdcn:main
Feb 5, 2026
Merged

fix: ensure resume args precede image args#10709
etraut-openai merged 1 commit intoopenai:mainfrom
cryptonerdcn:main

Conversation

@cryptonerdcn
Copy link
Contributor

Summary

Fixes argument ordering when resumeThread() is used with local_image. The SDK previously emitted CLI args with --image before resume <threadId>, which caused the Codex CLI to treat resume/UUID as image paths and start a new session. This PR moves resume <threadId> before any --image flags and adds a regression test.

Bug Report / Links

Repro (pre-fix)

  1. Build SDK from source
  2. Run resume + local_image
  3. Args order: --image <path> resume <id>
  4. Result: new session created (thread id changes)

Fix

Move resume <threadId> before --image in CodexExec.run and add a regression test to assert ordering.

Tests

  • cd sdk/typescript && npm test
    • Failed: codex-rs/target/debug/codex missing (ENOENT)

Notes

  • I can rerun tests in an environment with codex-rs built and report results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@cryptonerdcn
Copy link
Contributor Author

I have read and agree to the Contributor License Agreement (CLA).

@etraut-openai
Copy link
Collaborator

@cryptonerdcn, we've updated our contribution guidelines to indicate that we're no longer accepting unsolicited code contributions. All code contributions are by invitation only. To read more about why we've taken this step, please refer to this announcement.

That said, this is a nicely-scoped fix that's easy to review & validate, so consider yourself invited. :)

In the future, please discuss a fix in the issue tracker and wait for an invitation before opening a PR.

@etraut-openai
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai merged commit 1dc06b6 into openai:main Feb 5, 2026
10 of 17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants