state: enforce 10 MiB log caps for thread and threadless process logs by charley-oai · Pull Request #12038 · openai/codex

charley-oai · 2026-02-17T21:07:05Z

Summary

enforce a 10 MiB cap per thread_id in state log storage
enforce a 10 MiB cap per process_uuid for threadless (thread_id IS NULL) logs
scope pruning to only keys affected by the current insert batch
add a cheap per-key SUM(...) precheck so windowed prune queries only run for keys that are currently over the cap
add SQLite indexes used by the pruning queries
add focused runtime tests covering both pruning behaviors

Why

This keeps log growth bounded by the intended partition semantics while preserving a small, readable implementation localized to the existing insert path.

Local Latency Snapshot (No Truncation-Pressure Run)

Collected from session 019c734f-1d16-7002-9e00-c966c9fbbcae using local-only (uncommitted) instrumentation, while not specifically benchmarking the truncation-heavy regime.

Percentiles By Query (ms)

query	count	p50	p90	p95	p99	max
`insert_logs.insert_batch`	110	0.332	0.999	1.811	2.978	3.493
`insert_logs.precheck.process`	106	0.074	0.152	0.206	0.258	0.426
`insert_logs.precheck.thread`	73	0.118	0.206	0.253	1.025	1.025
`insert_logs.prune.process`	58	0.291	0.576	0.607	1.088	1.088
`insert_logs.prune.thread`	44	0.318	0.467	0.728	0.797	0.797
`insert_logs.prune_total`	110	0.488	0.976	1.237	1.593	1.684
`insert_logs.total`	110	1.315	2.889	3.623	5.739	5.961
`insert_logs.tx_begin`	110	0.133	0.235	0.282	0.412	0.546
`insert_logs.tx_commit`	110	0.259	0.689	0.772	1.065	1.080

`insert_logs.total` Histogram (ms)

bucket	count
`<= 0.100`	0
`<= 0.250`	0
`<= 0.500`	7
`<= 1.000`	33
`<= 2.000`	40
`<= 5.000`	28
`<= 10.000`	2
`<= 20.000`	0
`<= 50.000`	0
`<= 100.000`	0
`> 100.000`	0

Local Latency Snapshot (Truncation-Heavy / Cap-Hit Regime)

Collected from a run where cap-hit behavior was frequent (135/180 insert calls), using local-only (uncommitted) instrumentation and a temporary local cap of 10_000 bytes for stress testing (not the merged 10 MiB cap).

Percentiles By Query (ms)

query	count	p50	p90	p95	p99	max
`insert_logs.insert_batch`	180	0.524	1.645	2.163	3.424	3.777
`insert_logs.precheck.process`	171	0.086	0.235	0.373	0.758	1.147
`insert_logs.precheck.thread`	100	0.105	0.251	0.291	1.176	1.622
`insert_logs.prune.process`	109	0.386	0.839	1.146	1.548	2.588
`insert_logs.prune.thread`	56	0.253	0.550	1.148	2.484	2.484
`insert_logs.prune_total`	180	0.511	1.221	1.695	4.548	5.512
`insert_logs.total`	180	1.631	3.902	5.103	8.901	9.095
`insert_logs.total_cap_hit`	135	1.876	4.501	5.547	8.902	9.096
`insert_logs.total_no_cap_hit`	45	0.520	1.700	2.079	3.294	3.294
`insert_logs.tx_begin`	180	0.109	0.253	0.287	1.088	1.406
`insert_logs.tx_commit`	180	0.267	0.813	1.170	2.497	2.574

`insert_logs.total` Histogram (ms)

bucket	count
`<= 0.100`	0
`<= 0.250`	0
`<= 0.500`	16
`<= 1.000`	39
`<= 2.000`	60
`<= 5.000`	54
`<= 10.000`	11
`<= 20.000`	0
`<= 50.000`	0
`<= 100.000`	0
`> 100.000`	0

`insert_logs.total` Histogram When Cap Was Hit (ms)

bucket	count
`<= 0.100`	0
`<= 0.250`	0
`<= 0.500`	0
`<= 1.000`	22
`<= 2.000`	51
`<= 5.000`	51
`<= 10.000`	11
`<= 20.000`	0
`<= 50.000`	0
`<= 100.000`	0
`> 100.000`	0

Performance Takeaways

Even in a cap-hit-heavy run (75% cap-hit calls), insert_logs.total stays sub-10ms at p99 (8.901ms) and max (9.095ms).
Calls that did not hit the cap are materially cheaper (insert_logs.total_no_cap_hit p95 2.079ms) than cap-hit calls (insert_logs.total_cap_hit p95 5.547ms).
Compared to the earlier non-truncation-pressure run, overall insert_logs.total rose from p95 3.623ms to p95 5.103ms (+1.48ms), indicating bounded overhead when pruning is active.
This truncation-heavy run used an intentionally low local cap for stress testing; with the real 10 MiB cap, cap-hit frequency should be much lower in normal sessions.

Codex author

codex resume 019c6792-fed7-76f3-b94c-c7f3df43bf66

charley-oai · 2026-02-17T21:12:43Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a55b4f043

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/state/src/runtime.rs

charley-oai · 2026-02-17T21:33:12Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6274c296fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/state/src/runtime.rs

charley-oai · 2026-02-17T22:56:46Z

@codex review this

chatgpt-codex-connector · 2026-02-17T23:00:25Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-02-17T23:54:35Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f63a77f11a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/state/src/runtime.rs

charley-oai · 2026-02-18T01:58:25Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c87e90ac4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/state/src/runtime.rs

charley-oai · 2026-02-18T03:31:30Z

@codex review this

chatgpt-codex-connector · 2026-02-18T03:35:15Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai

Good for me. If the write load is too high we could run it only x% of the time as I don't think an overshoot is a big deal

jif-oai · 2026-02-18T13:30:12Z

codex-rs/state/src/runtime.rs

+const LOG_PARTITION_SIZE_LIMIT_BYTES: i64 = 10 * 1024 * 1024;
+// Estimated payload bytes used for partition caps. This intentionally ignores
+// SQLite storage overhead and focuses on user-visible log content size.
+const LOG_ROW_ESTIMATED_BYTES_SQL: &str = r#"


We could compute it up-front at insertion time to make the rest faster (read >> write)

state: prune log partitions to 10 MiB by thread and process

6a55b4f

chatgpt-codex-connector bot reviewed Feb 17, 2026

View reviewed changes

codex-rs/state/src/runtime.rs Show resolved Hide resolved

charley-oai added 3 commits February 17, 2026 13:18

state: precheck log partition size before prune window query

b82dfd4

state: add comments for log partition pruning

2964470

state: prune threadless null-process log partition

6274c29

chatgpt-codex-connector bot reviewed Feb 17, 2026

View reviewed changes

codex-rs/state/src/runtime.rs Show resolved Hide resolved

state: keep newest oversized log row during pruning

204fa38

charley-oai added 2 commits February 17, 2026 15:42

state: extract log pruning from insert_logs

a5a06ac

state: document threadless pruning semantics

f63a77f

chatgpt-codex-connector bot reviewed Feb 17, 2026

View reviewed changes

codex-rs/state/src/runtime.rs Outdated Show resolved Hide resolved

state: prune oversized newest rows to enforce strict cap

8c87e90

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

codex-rs/state/src/runtime.rs Outdated Show resolved Hide resolved

charley-oai added 2 commits February 17, 2026 18:30

state: make log insert and prune atomic

dc85ba2

state: satisfy clippy explicit-auto-deref in log tx path

27153e6

jif-oai approved these changes Feb 18, 2026

View reviewed changes

charley-oai force-pushed the cc/log-prune-10mib branch from 8cf291c to 27153e6 Compare February 18, 2026 22:21

charley-oai added 3 commits February 18, 2026 14:27

state: persist per-log estimated bytes for pruning

b731d6f

state: inline estimated_bytes expression in prune queries

01ed15e

state: clarify log partition definition in cap comment

c4a5736

charley-oai merged commit 7f3dbae into main Feb 19, 2026
41 of 45 checks passed

charley-oai deleted the cc/log-prune-10mib branch February 19, 2026 01:08

github-actions bot locked and limited conversation to collaborators Feb 19, 2026

Conversation

charley-oai commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Local Latency Snapshot (No Truncation-Pressure Run)

Percentiles By Query (ms)

insert_logs.total Histogram (ms)

Local Latency Snapshot (Truncation-Heavy / Cap-Hit Regime)

Percentiles By Query (ms)

insert_logs.total Histogram (ms)

insert_logs.total Histogram When Cap Was Hit (ms)

Performance Takeaways

Codex author

Uh oh!

charley-oai commented Feb 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 17, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 17, 2026

Uh oh!

charley-oai commented Feb 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector bot commented Feb 18, 2026

Uh oh!

jif-oai left a comment

Choose a reason for hiding this comment

Uh oh!

jif-oai Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

charley-oai commented Feb 17, 2026 •

edited

Loading

`insert_logs.total` Histogram (ms)

`insert_logs.total` Histogram (ms)

`insert_logs.total` Histogram When Cap Was Hit (ms)