tui: restore visible line numbers for hidden file links#12870
tui: restore visible line numbers for hidden file links#12870pash-openai merged 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8371ab742e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3e5363fe9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
we recently changed file linking so the model uses markdown links when it wants something to be clickable.
This works well across the GUI surfaces because they can render markdown cleanly and use the full absolute path in the anchor target.
A previous pass hid the absolute path in the TUI (and only showed the label), but that also meant we could lose useful location info when the model put the line number or range in the anchor target instead of the label.
This follow-up keeps the TUI behavior simple while making local file links feel closer to the old TUI file reference style.
key changes:
some examples:
[foo.rs](/abs/path/foo.rs)renders asfoo.rs[foo.rs](/abs/path/foo.rs:45)renders asfoo.rs:45[foo.rs](/abs/path/foo.rs:45:3-48:9)renders asfoo.rs:45:3-48:9[foo.rs:45](/abs/path/foo.rs:45)staysfoo.rs:45[docs](https://example.com/docs)still renders like a normal web linkhow it looks:
