Use model catalog default for reasoning summary fallback#12873
Merged
pakrym-oai merged 6 commits intomainfrom Feb 26, 2026
Merged
Use model catalog default for reasoning summary fallback#12873pakrym-oai merged 6 commits intomainfrom
pakrym-oai merged 6 commits intomainfrom
Conversation
Keep config/session summary optional so missing values fall back to the model catalog default when building TurnContext, while TurnContext and request paths remain concrete. Also add protocol support for default_reasoning_summary with backward-compatible serde defaults. Co-authored-by: Codex <noreply@openai.com>
Add a client integration test that verifies explicit model_reasoning_summary=none still omits reasoning.summary even when the model catalog default is detailed, and update suite tests for optional config summary + new model metadata field. Co-authored-by: Codex <noreply@openai.com>
This was referenced Feb 26, 2026
Update test fixtures and call sites for optional model reasoning summary and clean up a clippy redundant clone lint. Co-authored-by: Codex <noreply@openai.com>
aibrahim-oai
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.model_reasoning_summaryoptional so unset means use model defaultTurnContextdefault_reasoning_summaryin model metadataValidation
cargo test -p codex-core --lib client::tests -- --nocapture