queue slash commands in tui by charley-oai · Pull Request #14170 · openai/codex

charley-oai · 2026-03-10T04:23:16Z

Summary

make slash commands entered during a running turn queue instead of failing immediately
cover queued /review behavior and inline slash-command variants in the TUI tests
update the queued-command snapshot to reflect the new pending state

Testing

just fmt
cargo test -p codex-tui

charley-oai · 2026-03-11T02:42:22Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 30106e2b31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-11T07:58:53Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee775bbfdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-11T19:02:29Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c0d86ad38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-11T20:04:35Z

codex-rs/tui/src/bottom_pane/mod.rs

            if key_event.code == KeyCode::Esc
                && matches!(key_event.kind, KeyEventKind::Press | KeyEventKind::Repeat)
                && self.is_task_running
-                && !is_agent_command


The old && !is_agent_command guard was a heuristic workaround, not the real correctness condition.

Why it was added:

In 2a5bcc053f (fix: esc in /agent), /agent was a special case because typing past the command name hid the slash popup, so popup_active() was no longer protecting that flow.

At that point, Esc only interrupted in a narrower set of cases, and the guard was used to keep /agent draft editing from getting treated like a global interrupt.

Why it is safe to remove now:

The rule we want now is simpler and more correct: if a task is running and no popup/modal is active, Esc should interrupt.

That means the thing we should key off is actual UI state (popup_active() / modal stack), not the current text prefix.

Once the /agent popup is gone, there is no longer any agent-specific local UI to dismiss. At that point /agent is just ordinary composer text, and it should behave the same as any other nonempty draft.

Why the text-prefix check was the wrong abstraction:

It special-cased one command name instead of checking the actual thing that matters: whether the user is inside a local picker/dialog flow.

It was inconsistent with the newer behavior for other nonempty drafts, where Esc is intentionally allowed to interrupt.

It would have kept /agent as a one-off exception even after we explicitly changed the product behavior to allow interrupt with nonempty composer text.

Why this does not lose user state:

The interrupt path preserves the draft text; it does not clear the composer.

We also have coverage for the non-destructive behavior higher up in ChatWidget, so this is not “drop the command and interrupt”, it is “interrupt, while keeping the draft available”.

So the short version is: removing !is_agent_command is safe because popup/modal state is the real guard. /agent text by itself is not a meaningful interaction mode once its picker is gone.

charley-oai · 2026-03-11T20:07:14Z

codex-rs/tui/src/app.rs

+            AppEvent::HandleSlashCommandDraft(draft) => {
+                self.chat_widget.handle_serialized_slash_command(draft);
+                self.refresh_status_line();
+            }


Allows a slash command popup (e.g. model picker popup) to then submit a text slash command that can be queued or submitted

charley-oai · 2026-03-11T20:24:45Z

codex-rs/tui/src/chatwidget.rs

            self.restore_user_message_to_composer(combined);
        }
        self.refresh_pending_input_preview();
+        if !started_turn_after_interrupt {
+            self.maybe_send_next_queued_input();
+        }


we changed interrupt behavior so queued slash actions were no longer merged back into the composer

instead, they stayed queued and were replayed after interrupt

to make that work, we added drain_queued_inputs_until_blocked() at the end of on_interrupted_turn()

That new replay step created the race:

in the submit_pending_steers_after_interrupt path, on_interrupted_turn() calls submit_user_message(...)

but submit_user_message(...) does not synchronously mark the task as running

so the new post-interrupt replay could immediately start draining queued items before the replacement steer turn had actually started

started_turn_after_interrupt was added to block exactly that case.

charley-oai · 2026-03-11T23:41:22Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16ce18e9e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-12T18:24:20Z

codex-rs/tui/src/bottom_pane/chat_composer.rs

        {
-            if self.reject_slash_command_if_unavailable(cmd) {
-                return Some(InputResult::None);
-            }


This was "'/{}' is disabled while a task is in progress.", which we no longer emit

charley-oai · 2026-03-12T18:24:35Z

codex-rs/tui/src/bottom_pane/chat_composer.rs


-        if !cmd.supports_inline_args() {
-            return None;
-        }


Every command supports inline args now

charley-oai · 2026-03-12T18:52:08Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e8a7454ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-13T12:24:57Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d50dd10788

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-13T14:56:42Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6178ba4cb3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/app.rs

charley-oai · 2026-03-13T15:30:36Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba042b6f74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-13T15:51:44Z

@codex review this

Co-authored-by: Codex <noreply@openai.com>

Centralize slash command metadata, dedupe runtime builtin gating, and make popup-driven queued replay resume explicit. Co-authored-by: Codex <noreply@openai.com>

Remove the extra app-side popup completion latch so queued replay resumes whenever app events fully drain and ChatWidget is waiting to continue. Add an app-level regression for queued /personality followed by a queued user draft. Co-authored-by: Codex <noreply@openai.com>

Include builtin aliases when filtering the slash popup so valid commands like /multi-agents still surface the canonical /subagents entry. Reuse a shared command-name iterator for alias-aware builtin lookup and reserved-name filtering. Co-authored-by: Codex <noreply@openai.com>

Co-authored-by: Codex <noreply@openai.com>

charley-oai · 2026-03-16T07:49:05Z

@codex review this

chatgpt-codex-connector · 2026-03-16T07:59:04Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-03-16T18:27:39Z

Superseded by a stacked split:

tui: centralize slash command serialization #14835 tui: centralize slash command serialization
tui: queue slash commands in order #14836 tui: queue slash commands in order

Closing this draft to avoid duplicate review traffic.

This was referenced Mar 10, 2026

📊 AI CLI 工具社区动态日报 2026-03-10 gsscsd/big_model_radar#11

Open

📊 AI CLI 工具社区动态日报 2026-03-11 DenisZheng/agents-radar#7

Open

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

charley-oai commented Mar 11, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

This was referenced Mar 12, 2026

📊 AI CLI 工具社区动态日报 2026-03-12 DenisZheng/agents-radar#17

Closed

📊 AI CLI Tools Digest 2026-03-12 DenisZheng/agents-radar#18

Closed

📊 AI CLI 工具社区动态日报 2026-03-12 gsscsd/big_model_radar#22

Open

charley-oai force-pushed the cc/queue-tui-slash-commands branch from 679b033 to 51966cc Compare March 12, 2026 17:38

charley-oai commented Mar 12, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 12, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

charley-oai added a commit that referenced this pull request Mar 13, 2026

codex: fix CI failure on PR #14170

b56ff7b

Co-authored-by: Codex <noreply@openai.com>

charley-oai added a commit that referenced this pull request Mar 13, 2026

codex: fix windows slash help snapshots (#14170)

6178ba4

Co-authored-by: Codex <noreply@openai.com>

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

charley-oai and others added 25 commits March 15, 2026 23:32

tui: clear empty-arg slash drafts on dispatch

02f6733

Co-authored-by: Codex <noreply@openai.com>

tui: classify slash commands by execution kind

027524d

Co-authored-by: Codex <noreply@openai.com>

tui: run legacy sandbox preflight before enable

7e91f70

Co-authored-by: Codex <noreply@openai.com>

tui: refresh windows slash help snapshots

5ebd348

Co-authored-by: Codex <noreply@openai.com>

tui: encode queued resume paths losslessly

51d1e06

Co-authored-by: Codex <noreply@openai.com>

tui: complete legacy sandbox preflight asynchronously

39f436f

Co-authored-by: Codex <noreply@openai.com>

tui: align slash help subagents naming

eb31929

Co-authored-by: Codex <noreply@openai.com>

tui: pause replay after personality updates

90e964f

Co-authored-by: Codex <noreply@openai.com>

tui: restore multi-agents slash alias

d65960d

Co-authored-by: Codex <noreply@openai.com>

tui: dedupe alias-expanded popup commands

1a54e52

Co-authored-by: Codex <noreply@openai.com>

tui: gate slash help by runtime availability

a6ffd1c

Co-authored-by: Codex <noreply@openai.com>

tui: reserve builtin aliases in command popup

e0627c8

Co-authored-by: Codex <noreply@openai.com>

tui: preserve queued drafts across session switches

6d0be7f

Co-authored-by: Codex <noreply@openai.com>

tui: gate inline feedback command

f34490a

Co-authored-by: Codex <noreply@openai.com>

tui: fix windows selection action inference

6cc1476

Co-authored-by: Codex <noreply@openai.com>

tui: defer windows sandbox popup selection

8d3ed74

Co-authored-by: Codex <noreply@openai.com>

tui: queue smart approvals updates

11d49d9

Co-authored-by: Codex <noreply@openai.com>

codex: address PR review feedback (#14170)

3b8dbed

Co-authored-by: Codex <noreply@openai.com>

codex: address PR review feedback (#14170)

89f7c08

Co-authored-by: Codex <noreply@openai.com>

codex: fix windows help snapshots (#14170)

5d81980

Co-authored-by: Codex <noreply@openai.com>

tui: simplify slash command policy wiring

9ec1452

Centralize slash command metadata, dedupe runtime builtin gating, and make popup-driven queued replay resume explicit. Co-authored-by: Codex <noreply@openai.com>

tui: accept plain p in help search

ef28639

Co-authored-by: Codex <noreply@openai.com>

tui: wait for async slash replay updates

6c9bac8

Co-authored-by: Codex <noreply@openai.com>

charley-oai force-pushed the cc/queue-tui-slash-commands branch from b237ca7 to 6c9bac8 Compare March 16, 2026 06:36

charley-oai closed this Mar 16, 2026

Conversation

charley-oai commented Mar 10, 2026

Summary

Testing

Uh oh!

charley-oai commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charley-oai Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

charley-oai commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai commented Mar 12, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

charley-oai Mar 11, 2026 •

edited

Loading

charley-oai Mar 11, 2026 •

edited

Loading