Add Codex Apps sediment file remapping by caseychow-oai · Pull Request #15197 · openai/codex

caseychow-oai · 2026-03-19T17:50:20Z

Summary

bridge Codex Apps MCP declared file inputs/outputs through the OpenAI files flow behind the apps_file_bridge feature flag
upload local file path inputs for declared openai/fileParams fields and rewrite them into canonical OpenAI file payload objects
auto-download declared openai/fileOutputs sediment://{file_id} results into managed temp paths and expose the explicit download_openai_file tool when the feature is enabled
scope managed OpenAI file downloads to a per-session temp root and add that root to the session sandbox only when the feature is enabled

Notes

Remote MCP file references in the argument rewrite path must be explicit sediment://...; bare file_* / file-* strings are treated as local paths.
During cleanup, removing the earlier macOS-specific model_availability_nux test relaxation reproduced the local Bazel failure unexpected exit code from codex resume: 1; output: ^C, so that narrow allowance remains.
The test-only shell snapshot timing adjustment remains in suite::shell_snapshot::shell_command_snapshot_still_intercepts_apply_patch because removing it reproduced the macOS x86 local Bazel failure timed out waiting for file .../snapshot-apply.txt.

Verification

cargo test -p codex-core rewrite_single_argument_string_ -- --nocapture
cargo test -p codex-core openai_file_ -- --nocapture
cargo test -p codex-core mcp_tool_to_openai_tool_ -- --nocapture
cargo test -p codex-core prompt_tools_are_consistent_across_requests -- --nocapture
cargo test -p codex-core serialize_tool_search_output_tools_ -- --nocapture
cargo test -p codex-features
~/.cargo/bin/just fmt

mzeng-openai · 2026-03-20T20:25:46Z

there's one real bug here: in rewrite_single_argument_string we parse bare file_*/file-* as OpenAI file IDs before trying to resolve a local path, so a local file like file_report.csv gets rewritten to sediment://file_report.csv instead of being uploaded. can we either require sediment:// for remote handles in this path, or check local path existence first?

also, can we split out the unrelated cleanup from this PR? the nextest / approval-matrix / code-mode timing changes, cargo-bin refactor, apply_patch fallback, and app-server fileChange test relaxation don't seem tied to the sediment bridge.

caseychow-oai · 2026-03-20T20:33:09Z

there's one real bug here: in rewrite_single_argument_string we parse bare file_*/file-* as OpenAI file IDs before trying to resolve a local path, so a local file like file_report.csv gets rewritten to sediment://file_report.csv instead of being uploaded. can we either require sediment:// for remote handles in this path, or check local path existence first?

will investigate

also, can we split out the unrelated cleanup from this PR? the nextest / approval-matrix / code-mode timing changes, cargo-bin refactor, apply_patch fallback, and app-server fileChange test relaxation don't seem tied to the sediment bridge.

wilco, was trying to remove as much of that as possible but kept breaking CI. if i can make it work without i'll try to remove

caseychow-oai · 2026-03-20T20:46:07Z

Removing local fallback entirely, we should always assume it's sediment:// for remote files here.

mzeng-openai · 2026-03-21T23:27:22Z

codex-rs/tui/tests/suite/model_availability_nux.rs

    let interrupt_writer = writer_tx.clone();
    let interrupt_task = tokio::spawn(async move {
-        sleep(Duration::from_secs(2)).await;
+        let interrupt_delay = if cfg!(target_os = "macos") {


Can we clean up the unrelated diffs here and in other places.

mzeng-openai · 2026-03-21T23:30:22Z

codex-rs/core/src/mcp_tool_call.rs

    sess: Arc<Session>,
    turn_context: &Arc<TurnContext>,
    call_id: String,
+    qualified_tool: QualifiedMcpTool<'_>,


Why do we need change the core flow here? Can we move the file transformation logic out of the core flow as much as possible? Essentially you only need to rewrite a few special params and I don't think you have to change the whole core flow to achieve that.

mzeng-openai · 2026-03-21T23:32:43Z

codex-rs/core/src/tools/handlers/mcp.rs

            session,
            turn,
            call_id,
+            tool_name,


Same here, do we have to change the core flow?

mzeng-openai · 2026-03-21T23:33:15Z

codex-rs/core/src/tools/handlers/tool_search.rs

 impl ToolSearchHandler {
-    pub fn new(tools: HashMap<String, ToolInfo>) -> Self {
-        Self { tools }
+    pub fn new(tools: HashMap<String, ToolInfo>, openai_file_bridge_enabled: bool) -> Self {


I don't think you need to add it to tool search.

There's two main things that we have to make sure to expose to the model, and the tool results seems to be the best thing. First is that we need to modify the parameter so that it is showing the model file shape instead of the path. The second is that we need to indicate to the model that that is what is happening on both the upload and the download flows.

I've gone ahead and tried to streamline it as much as possible to isolate it to just the case that we're caring about. If you feel like we can go further I'm happy to take a shot.

codex-rs/core/src/tools/spec.rs

mzeng-openai · 2026-03-21T23:37:15Z

codex-rs/core/tests/suite/shell_snapshot.rs


 async fn wait_for_file_contents(path: &Path) -> Result<String> {
-    let deadline = Instant::now() + Duration::from_secs(5);
+    let file_wait_timeout = if cfg!(target_os = "macos") {


Also please clean up here.

mzeng-openai · 2026-03-21T23:38:31Z

codex-rs/core/src/codex.rs

 }

 impl Session {
+    fn add_session_openai_file_root_to_sandbox(


Can you confirm with @bolinfest if this is ok with the sandbox policy?

Bridge Codex Apps file params and outputs through sediment handles, add a dedicated download tool, and harden test/runtime paths used during verification. Co-authored-by: Codex <noreply@openai.com>

Co-authored-by: Codex <noreply@openai.com>

Tighten Codex Apps MCP file argument rewriting so remote handles must be explicit sediment:// URIs, and trim unrelated CI/test/runtime changes from this branch. Co-authored-by: Codex <noreply@openai.com>

Co-authored-by: Codex <noreply@openai.com>

caseychow-oai force-pushed the casey/openai-files-codex-apps branch 3 times, most recently from 479d6f8 to ce24846 Compare March 20, 2026 18:54

ambroise-oai requested a review from mzeng-openai March 20, 2026 19:02

caseychow-oai force-pushed the casey/openai-files-codex-apps branch 3 times, most recently from e4acb53 to 3f800e2 Compare March 20, 2026 23:59

github-actions bot mentioned this pull request Mar 21, 2026

📊 AI CLI 工具社区动态日报 2026-03-21 gsscsd/big_model_radar#70

Open

caseychow-oai force-pushed the casey/openai-files-codex-apps branch 2 times, most recently from f370d7f to 2c77356 Compare March 21, 2026 20:39

mzeng-openai reviewed Mar 21, 2026

View reviewed changes

codex-rs/core/src/tools/spec.rs Outdated Show resolved Hide resolved

mzeng-openai reviewed Mar 21, 2026

View reviewed changes

This was referenced Mar 22, 2026

📊 AI CLI 工具社区动态日报 2026-03-22 gsscsd/big_model_radar#75

Open

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-22 compasify/agents-radar#70

Open

caseychow-oai force-pushed the casey/openai-files-codex-apps branch 2 times, most recently from 68912ab to 4557a14 Compare March 23, 2026 19:28

caseychow-oai and others added 6 commits March 23, 2026 21:13

Add Codex Apps sediment file remapping

b722878

Bridge Codex Apps file params and outputs through sediment handles, add a dedicated download tool, and harden test/runtime paths used during verification. Co-authored-by: Codex <noreply@openai.com>

Fix argument comment lint in file rewrite

a8702d6

Co-authored-by: Codex <noreply@openai.com>

Collapse cargo-bin fallback if for clippy

be296b2

Co-authored-by: Codex <noreply@openai.com>

Fix codex-core clippy and code mode CI issues

0a21199

Co-authored-by: Codex <noreply@openai.com>

Stabilize CI for apply patch approval tests

2a460d6

Co-authored-by: Codex <noreply@openai.com>

Stabilize remaining approval test failures

33cf037

Co-authored-by: Codex <noreply@openai.com>

caseychow-oai and others added 28 commits March 23, 2026 21:13

Fix same-origin openai file auth test

240f91e

Co-authored-by: Codex <noreply@openai.com>

Relax file change approval delta assertions

52a405e

Co-authored-by: Codex <noreply@openai.com>

Gate Codex Apps file bridge behind feature flag

17e2e5b

Co-authored-by: Codex <noreply@openai.com>

Require sediment URIs for MCP file args

f9ff329

Tighten Codex Apps MCP file argument rewriting so remote handles must be explicit sediment:// URIs, and trim unrelated CI/test/runtime changes from this branch. Co-authored-by: Codex <noreply@openai.com>

Fix stale MCP approval metadata test

39ac2cc

Co-authored-by: Codex <noreply@openai.com>

Update schema and tool spec fixtures

61dfe23

Co-authored-by: Codex <noreply@openai.com>

Fix Codex Apps file bridge metadata

66f114f

Co-authored-by: Codex <noreply@openai.com>

Fix MCP lint regressions

0676595

Co-authored-by: Codex <noreply@openai.com>

Scope OpenAI file temp roots per session

9bd008c

Co-authored-by: Codex <noreply@openai.com>

Gate session temp sandbox root behind apps file bridge

a3e22b3

Co-authored-by: Codex <noreply@openai.com>

Relax macOS Bazel timing in smoke-style tests

fe4422d

Co-authored-by: Codex <noreply@openai.com>

Revert resume timing test relaxation

4779419

Co-authored-by: Codex <noreply@openai.com>

Revert shell snapshot timing relaxation

0a19290

Co-authored-by: Codex <noreply@openai.com>

Restore shell snapshot timing fix after cleanup rebase

c8fa38d

Co-authored-by: Codex <noreply@openai.com>

Restore macOS resume test allowance

fe738eb

Co-authored-by: Codex <noreply@openai.com>

refactor: remove manual OpenAI file download tool

3f67083

Co-authored-by: Codex <noreply@openai.com>

refactor: narrow MCP tool metadata plumbing

5b67e86

Co-authored-by: Codex <noreply@openai.com>

refactor: isolate qualified MCP metadata lookup

669f7a4

Co-authored-by: Codex <noreply@openai.com>

test: drop resume timing relaxation experiment

c0d2d8e

Co-authored-by: Codex <noreply@openai.com>

test: drop shell snapshot timing relaxation experiment

b06406a

Co-authored-by: Codex <noreply@openai.com>

docs: clarify apps file bridge path guidance

3423bbf

refactor: make apps file bridge upload-only

063f310

Co-authored-by: Codex <noreply@openai.com>

refactor: remove stale file bridge sandbox plumbing

87d8408

Co-authored-by: Codex <noreply@openai.com>

fix: restore test-only file bridge helpers

5ee3a1e

Co-authored-by: Codex <noreply@openai.com>

fix: remove duplicate test cfg

9a401d7

Co-authored-by: Codex <noreply@openai.com>

test: restore macOS CI allowances

5682f32

Co-authored-by: Codex <noreply@openai.com>

Revert "test: restore macOS CI allowances"

3082c12

Co-authored-by: Codex <noreply@openai.com>

test: restore macOS smoke allowances

c217e5c

Co-authored-by: Codex <noreply@openai.com>

caseychow-oai force-pushed the casey/openai-files-codex-apps branch from a661bc0 to c217e5c Compare March 24, 2026 00:23

github-actions bot mentioned this pull request Mar 24, 2026

📊 AI CLI 工具社区动态日报 2026-03-24 gsscsd/big_model_radar#86

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Codex Apps sediment file remapping#15197

Add Codex Apps sediment file remapping#15197
caseychow-oai wants to merge 40 commits intomainfrom
casey/openai-files-codex-apps

caseychow-oai commented Mar 19, 2026 •

edited

Loading

Uh oh!

mzeng-openai commented Mar 20, 2026

Uh oh!

caseychow-oai commented Mar 20, 2026

Uh oh!

caseychow-oai commented Mar 20, 2026

Uh oh!

mzeng-openai Mar 21, 2026

Uh oh!

mzeng-openai Mar 21, 2026

Uh oh!

mzeng-openai Mar 21, 2026

Uh oh!

mzeng-openai Mar 21, 2026

Uh oh!

caseychow-oai Mar 23, 2026

Uh oh!

Uh oh!

mzeng-openai Mar 21, 2026

Uh oh!

mzeng-openai Mar 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

caseychow-oai commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Notes

Verification

Uh oh!

mzeng-openai commented Mar 20, 2026

Uh oh!

caseychow-oai commented Mar 20, 2026

Uh oh!

caseychow-oai commented Mar 20, 2026

Uh oh!

mzeng-openai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

mzeng-openai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

mzeng-openai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

mzeng-openai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

caseychow-oai Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mzeng-openai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

mzeng-openai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

caseychow-oai commented Mar 19, 2026 •

edited

Loading