chore(core) Add approvals reviewer to UserTurn#15426
Merged
dylan-hurd-oai merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
charley-oai
approved these changes
Mar 21, 2026
|
|
||
| /// Reviewer to use for approval requests raised during this turn. | ||
| /// | ||
| /// When omitted, the session keeps the current setting |
Collaborator
There was a problem hiding this comment.
what if it's the first turn?
Collaborator
Author
There was a problem hiding this comment.
Would just be the session default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for approvals_reviewer to
Op::UserTurnso we can migrate[CodexMessageProcessor::turn_start]to use Op::UserTurnTesting