-
Notifications
You must be signed in to change notification settings - Fork 4.4k
TUI: show full patch diff in approval modal #2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds create_diff_details to display
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@vmotta8 is there a way to show the diff even when there is auto approve? I just want to follow the edits and stop the model in case it goes sideways. |
Possibly related? #2049 |
@nestedlogicsol oh, you're right, and this pr does almost the same thing: #2050 |
I don't see any evidence of the approval dialogue. How did you get it to work in your environment? |
@nestedlogicsol You can build a release binary using |
@vmotta8 sorry I was unclear - I meant that I didn't see evidence of fixing the missing "proposed patch" functionality in #2049 & #2050 that seems to be present in your PR. They've merged 2049 and 2050 into main, I bet you can use their new diff implementation combined with your "proposed patch" fix (maybe your changes to trust_directory.rs?) to cover all the issues we've talked about so far. |
@nestedlogicsol Sure! I’ve updated it to keep the new diff implementation from main, and now it only contains the fix for the missing “proposed patch” functionality. |
Description
apply_patch
command generates requests with illegible diff #2005Screenshots:

