Skip to content

Conversation

vmotta8
Copy link

@vmotta8 vmotta8 commented Aug 11, 2025

Description

Screenshots:
Screenshot 2025-08-12 at 08 22 00
Screenshot 2025-08-14 at 13 01 24

Copy link

github-actions bot commented Aug 11, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@vmotta8
Copy link
Author

vmotta8 commented Aug 11, 2025

I have read the CLA Document and I hereby sign the CLA

@overthetop
Copy link

@vmotta8 is there a way to show the diff even when there is auto approve? I just want to follow the edits and stop the model in case it goes sideways.

@nestedlogicsol
Copy link

nestedlogicsol commented Aug 11, 2025

Possibly related? #2049

@vmotta8
Copy link
Author

vmotta8 commented Aug 11, 2025

@nestedlogicsol oh, you're right, and this pr does almost the same thing: #2050
@overthetop this pr will address your point as well
it will probably be merged soon

@nestedlogicsol
Copy link

I don't see any evidence of the approval dialogue. How did you get it to work in your environment?

@vmotta8
Copy link
Author

vmotta8 commented Aug 11, 2025

@nestedlogicsol You can build a release binary using cargo build --release --bin codex inside codex-rs and then run the executable from any directory
The binary will be generated in target/release/codex

@nestedlogicsol
Copy link

@vmotta8 sorry I was unclear - I meant that I didn't see evidence of fixing the missing "proposed patch" functionality in #2049 & #2050 that seems to be present in your PR.

They've merged 2049 and 2050 into main, I bet you can use their new diff implementation combined with your "proposed patch" fix (maybe your changes to trust_directory.rs?) to cover all the issues we've talked about so far.

@vmotta8
Copy link
Author

vmotta8 commented Aug 12, 2025

@nestedlogicsol Sure! I’ve updated it to keep the new diff implementation from main, and now it only contains the fix for the missing “proposed patch” functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants