Pretty-print config.toml when saving #2233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
Aug 13, 2025
dylan-hurd-oai
requested changes
Aug 13, 2025
bolinfest
requested changes
Aug 13, 2025
|
@bolinfest if we use toml_edit correctly it should preserve comments, but also agree with making minimal edits |
|
@dylan-hurd-oai I agree, but this does not appear to be using tomledit? |
|
yep, that is why i also requested changes! |
|
Sorry, I saw the green checkmark first and just replied! |
|
Fair! I missed the green checkmark and also just jumped in to reject 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
just fmtjust fix(fails:letexpressions in this position are unstable)cargo test --all-features(fails:letexpressions in this position are unstable)https://chatgpt.com/codex/tasks/task_i_689b66284b38832d9d77f3b9e6fdeb80