Fix build break and build release #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
changed the title
bolinfest
approved these changes
Aug 12, 2025
| profile: dev | ||
| - runner: macos-14 | ||
| target: aarch64-apple-darwin | ||
| profile: release |
There was a problem hiding this comment.
Does this one build the fastest? And can you add a comment here because it's a bit subtle since it's in the middle of the list?
Arguably we should do one Mac and one Linux release mode because there is stuff conditionally compiled for Landlock that sometimes I forget to test...
There was a problem hiding this comment.
Both release builds are slow so I kept them non-blocking for merge.
| @@ -77,7 +87,7 @@ jobs: | |||
| ~/.cargo/registry/cache/ | |||
| ~/.cargo/git/db/ | |||
| ${{ github.workspace }}/codex-rs/target/ | |||
| key: cargo-${{ matrix.runner }}-${{ matrix.target }}-${{ hashFiles('**/Cargo.lock') }} | |||
| key: cargo-${{ matrix.runner }}-${{ matrix.target }}-${{ matrix.profile }}-${{ hashFiles('**/Cargo.lock') }} | |||
There was a problem hiding this comment.
Can/should we update rust-release.yml to match and get cache hits?
…key for release builds
bolinfest
approved these changes
Aug 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build release profile for one configuration.