add a github action to test the nix flake works and doesn't break#2527
add a github action to test the nix flake works and doesn't break#2527jessfraz wants to merge 77 commits intoopenai:mainfrom
Conversation
Signed-off-by: Jessie Frazelle <github@jessfraz.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
I will also fix the flake... since it's broken. |
|
Cool it works now. |
|
if this breaks again once you have the github action, o3 is great at unfucking these things, but also you can ping me |
Signed-off-by: Jessie Frazelle <github@jessfraz.com>
Signed-off-by: Jessie Frazelle <github@jessfraz.com>
|
Interested in this as well, gentle ping for review @tibo-openai 🙏 |
| lockFile = ./Cargo.lock; | ||
| # ratatui is patched via git, so we must whitelist its fixed-output hash | ||
| outputHashes = { | ||
| "ratatui-0.29.0" = "sha256-HBvT5c8GsiCxMffNjJGLmHnvG77A6cqEL+1ARurBXho="; |
There was a problem hiding this comment.
I'm afraid this cannot be managed by dependabot or any automated system.
There was a problem hiding this comment.
Yeah its super unfortunate, and according to our mutual friend, o3, this seems like the lesser of evils...
I presume you all plan on getting your changes merged to ratatui upstream, that would definitely clean it up. But I'm also happy to help, this flake is a part of my dotfiles now, so you all can ping me whenever the action breaks, honestly I'd much prefer being pinged than the flake not work :)
There was a problem hiding this comment.
(Pls excuse the drive-by commenting)
If you do want to maintain this long term, you can write a small script that does something to the effect of nix-prefetch-url --unpack --type sha256 $URL and writes it into something like foo.nix then do import ./foo.nix there. Give or take some datastructure adjustments.
There was a problem hiding this comment.
ya that seems like a lot of extra work for something where there hasnt been changes in 3 weeks: https://github.com/nornagon/ratatui/tree/nornagon-v0.29.0-patch I'd like to better understand the plans to upstream
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
Co-authored-by: Kamil Zabielski <50334623+limakzi@users.noreply.github.com>
|
I would also appreciate if the flake worked |
|
For anyone else waiting for this to be merged, numtide have added codex to their ai-tools flake: |
|
i can close this thanks to #4048 |
I think your nix flake is broken and this will:
Relevant issue: #241