-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix(tui): keep status indicator visible during streaming when message… #4864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
…s are queued Signed-off-by: vinay.badhan <[email protected]>
8e97195
to
d6c841f
Compare
recheck |
💡 Codex Reviewcodex/codex-rs/tui/src/chatwidget.rs Lines 635 to 639 in 8e97195
The new guard in ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
recheck |
Fixes #4446 - Messages sent while final output text is streamed are now properly
queued and visible in the status indicator instead of appearing to be injected
into the streamed text.
The issue occurred because the status indicator (which displays queued messages)
was being hidden during content commits, making queued messages appear as if
they were injected into the streamed text rather than properly queued.