Skip to content

fix(tui): keep status indicator visible during streaming when message… #4864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tui): keep status indicator visible during streaming when message… #4864

wants to merge 1 commit into from

Conversation

vinayb21-work
Copy link

Fixes #4446 - Messages sent while final output text is streamed are now properly
queued and visible in the status indicator instead of appearing to be injected
into the streamed text.

  • Don't hide status indicator during streaming if queued messages exist
  • Ensure queued messages remain visible throughout the streaming process
  • Add test to verify queued message behavior during streaming

The issue occurred because the status indicator (which displays queued messages)
was being hidden during content commits, making queued messages appear as if
they were injected into the streamed text rather than properly queued.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@vinayb21-work
Copy link
Author

recheck

@chatgpt-codex-connector ChatGPT Codex Connector
Copy link
Contributor

💡 Codex Review

codex/codex-rs/tui/src/chatwidget.rs

Lines 635 to 639 in 8e97195

// Don't hide the status indicator during streaming if there are queued messages
// This ensures queued messages remain visible to the user
if self.queued_user_messages.is_empty() {
self.bottom_pane.hide_status_indicator();
}

P1 Badge Status indicator still hidden when message queued mid-stream

The new guard in on_commit_tick only skips hiding the status indicator when queued messages already exist. During a typical turn the first commit tick runs while the queue is still empty, so hide_status_indicator() is called and the widget is removed. If the user queues a message after that point, nothing recreates the indicator—refresh_queued_user_messages() just updates an indicator that no longer exists—so the queued message list remains invisible despite the intent of the fix. To actually keep queued messages visible, the code needs to restore or avoid hiding the indicator when the queue transitions from empty to non-empty, not only skip later hides.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@vinayb21-work
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@vinayb21-work
Copy link
Author

recheck

@vinayb21-work
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@vinayb21-work
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@vinayb21-work
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messages sent while final output text is streamed are injected in UI then ignored, rather than properly queued
2 participants
@vinayb21-work @vinayb21-medable